From: Eli Zaretskii <eliz@gnu.org>
To: charles@aurox.ch
Cc: 34723@debbugs.gnu.org
Subject: bug#34723: 27.0.50; customize and improve diff-mode recentering
Date: Wed, 06 Mar 2019 18:06:14 +0200 [thread overview]
Message-ID: <83h8cgc7ih.fsf@gnu.org> (raw)
In-Reply-To: <m28sxtukfn.fsf@aurox.ch> (charles@aurox.ch)
> Date: Tue, 05 Mar 2019 21:37:32 +0100
> From: charles@aurox.ch (Charles A. Roelli)
> CC: 34723@debbugs.gnu.org
>
> > I don't understand what calling 'recenter' has to do with
> > scroll-conservatively. And scroll-conservatively is implemented in
> > the display engine, so I'm afraid I'm still in the dark regarding the
> > nature of the problem you are discussing.
>
> Does the following scenario make some sense? diff-hunk-next moves
> point to a position beyond (window-end), and immediately calls
> (recenter '(0)). Scrolling (which would otherwise respect
> scroll-conservatively) gets preempted by diff-hunk-next's call to
> recenter.
Why does it call 'recenter'? It must have a reason, doesn't it? Does
the history of that code gives a clue?
Note that without recentering, if you just move point to some location
in the diffs, when scroll-conservatively > 100, point will wind up
either on the last screen line of the window or its first screen line,
depending on whether you move forward or back in the buffer. The
latter might be okay, but the former will most probably hide most of
the hunk, which might be the reason for recentering (I'm just guessing
here).
next prev parent reply other threads:[~2019-03-06 16:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 20:38 bug#34723: 27.0.50; customize and improve diff-mode recentering Charles A. Roelli
2019-03-03 21:33 ` Juri Linkov
2019-03-04 19:06 ` Charles A. Roelli
2019-03-04 21:12 ` Juri Linkov
2019-03-05 16:11 ` Eli Zaretskii
2019-03-05 20:11 ` Charles A. Roelli
2019-03-05 20:22 ` Eli Zaretskii
2019-03-07 19:12 ` Charles A. Roelli
2019-03-05 15:46 ` Eli Zaretskii
2019-03-05 19:49 ` Charles A. Roelli
2019-03-05 19:44 ` Eli Zaretskii
2019-03-05 20:37 ` Charles A. Roelli
2019-03-06 16:06 ` Eli Zaretskii [this message]
2019-03-07 19:49 ` Charles A. Roelli
2019-03-13 19:40 ` Stefan Monnier
2019-03-13 19:56 ` Stefan Monnier
2019-03-16 19:39 ` Charles A. Roelli
2019-03-16 22:37 ` Stefan Monnier
2019-03-16 20:21 ` Charles A. Roelli
2019-03-22 19:32 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h8cgc7ih.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34723@debbugs.gnu.org \
--cc=charles@aurox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.