From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Line height issues with display-line-number-mode
Date: Wed, 08 May 2019 21:54:06 +0300
Message-ID: <83h8a4hj5d.fsf@gnu.org>
References: <6fd496f0-7dd5-6c0e-5121-b618e7dca831@gmail.com>
	<CAM-tV-8hTZXJ_9+6b_yvruwKmUgJftZUds9wArGpitUWf9ms+g@mail.gmail.com>
	<83sgtqi02k.fsf@gnu.org> <83r29ahyz2.fsf@gnu.org>
	<jwvftpqccin.fsf-monnier+emacs@gnu.org>
	<83pnouhwxs.fsf@gnu.org> <jwva7fyc9gv.fsf-monnier+emacs@gnu.org>
	<83ef59igzc.fsf@gnu.org> <jwv1s19vzq7.fsf-monnier+emacs@gnu.org>
	<83tve5ghyd.fsf@gnu.org>
	<CAM-tV-_j11YTT8CTWbKDYH19sM0nMOc1Xf4o=akVs6kw8qV=pQ@mail.gmail.com>
	<jwv1s19uh7m.fsf-monnier+emacs@gnu.org>
	<CAM-tV-8XfSsj9M0FG8KYwc6NkVrSguwA_8YPmNxg9kmTpU9pAg@mail.gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="185536"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
To: Noam Postavsky <npostavs@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 08 20:55:14 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hORik-000m7O-CT
	for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 20:55:14 +0200
Original-Received: from localhost ([127.0.0.1]:41828 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hORij-0001Ay-DD
	for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 14:55:13 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:57075)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hORhx-0001An-KS
	for emacs-devel@gnu.org; Wed, 08 May 2019 14:54:26 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56394)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hORhu-0001xF-KT; Wed, 08 May 2019 14:54:23 -0400
Original-Received: from [176.228.60.248] (port=2505 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hORhp-0002RN-QT; Wed, 08 May 2019 14:54:21 -0400
In-reply-to: <CAM-tV-8XfSsj9M0FG8KYwc6NkVrSguwA_8YPmNxg9kmTpU9pAg@mail.gmail.com>
	(message from Noam Postavsky on Wed, 8 May 2019 14:39:42 -0400)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:236312
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/236312>

> From: Noam Postavsky <npostavs@gmail.com>
> Date: Wed, 8 May 2019 14:39:42 -0400
> Cc: Eli Zaretskii <eliz@gnu.org>, Emacs developers <emacs-devel@gnu.org>
> 
> > That align-to computation looks brittle (and still incorrect, I think)
> > and it hardcodes into the text-property a value which can change later
> > (window-hscroll), so it's rather problematic.
> 
> Yes, in magit this is recomputed from
> redisplay-highlight-region-function, which keeps the value up to date,
> but has it's own problems (e.g., inf looping in redisplay Bug#24633,
> this is what `min' works around). I guess for *Help* buffers there's
> not much use in hscrolling, so using just '(space :align-to right)
> would be fine.

Maybe we should simply add a feature that would allow display of a
thin line across the window.  Then all of the problems we discussed
will just go away.