From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Docstring of make-symbolic-link Date: Tue, 11 Jun 2019 17:22:46 +0300 Message-ID: <83h88w9p6x.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="140157"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 11 16:27:57 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hahkh-000aJY-Pl for ged-emacs-devel@m.gmane.org; Tue, 11 Jun 2019 16:27:55 +0200 Original-Received: from localhost ([::1]:59538 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hahkg-0007n6-Dh for ged-emacs-devel@m.gmane.org; Tue, 11 Jun 2019 10:27:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38540) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hahfl-000484-Py for emacs-devel@gnu.org; Tue, 11 Jun 2019 10:22:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hahfk-0008E3-0F; Tue, 11 Jun 2019 10:22:48 -0400 Original-Received: from [176.228.60.248] (port=2600 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hahfj-0000oC-6u; Tue, 11 Jun 2019 10:22:47 -0400 In-reply-to: (message from Juanma Barranquero on Mon, 10 Jun 2019 21:44:46 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237432 Archived-At: > From: Juanma Barranquero > Date: Mon, 10 Jun 2019 21:44:46 +0200 > > make-symbolic link uses NEWNAME in its docstring, but LINKNAME as the > argument name: > > (make-symbolic-link TARGET LINKNAME &optional OK-IF-ALREADY-EXISTS) > > Make a symbolic link to TARGET, named NEWNAME. > If NEWNAME is a directory name, make a like-named symbolic link under > NEWNAME. > > [etc...] This appears to be some kind of copy-pasta from add-name-to-file, which creates a hard link. > The easiest way to fix it is to change NEWNAME to LINKNAME in the > docstring, but I think NEWNAME is the preferred name, and it is also > used in the info files. > > The alternative is to change linkname to newname in the code, and > encoded_linkname to encoded_newname (not required, but for > consistency). > > It is a trivial change, but as it touches code in 26.2.50, better safe > than sorry. So, newname everywhere, or linkname everywhere (including > the info files)? My vote is for LINKNAME.