From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34489: 25.2; pdb fails if directory contains '++' Date: Wed, 03 Jul 2019 08:39:19 +0300 Message-ID: <83h883d6d4.fsf@gnu.org> References: <87r2c94flq.fsf@sipc87.si.ehu.es> <835zonf2xh.fsf@gnu.org> <831rz8e6mw.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="61653"; mail-complaints-to="usenet@blaine.gmane.org" Cc: a.soroa@ehu.eus, 34489@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 03 07:41:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hiY0p-000Fo1-Jf for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jul 2019 07:40:59 +0200 Original-Received: from localhost ([::1]:32812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiY0o-0006fE-Dw for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jul 2019 01:40:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39787) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiY00-0006OD-Lq for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 01:40:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiXzz-0006Y2-P6 for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 01:40:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39490) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiXzu-0006VX-62 for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 01:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hiXzt-0000Ki-Tm for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 01:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jul 2019 05:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34489-submit@debbugs.gnu.org id=B34489.15621323861254 (code B ref 34489); Wed, 03 Jul 2019 05:40:01 +0000 Original-Received: (at 34489) by debbugs.gnu.org; 3 Jul 2019 05:39:46 +0000 Original-Received: from localhost ([127.0.0.1]:48311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiXze-0000KA-DU for submit@debbugs.gnu.org; Wed, 03 Jul 2019 01:39:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiXza-0000Jw-HG for 34489@debbugs.gnu.org; Wed, 03 Jul 2019 01:39:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hiXzQ-0006HT-RH; Wed, 03 Jul 2019 01:39:34 -0400 Original-Received: from [176.228.60.248] (port=4540 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hiXzP-0005zh-Ub; Wed, 03 Jul 2019 01:39:32 -0400 In-reply-to: (message from Stefan Kangas on Tue, 2 Jul 2019 21:42:31 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162006 Archived-At: > From: Stefan Kangas > Date: Tue, 2 Jul 2019 21:42:31 +0200 > Cc: a.soroa@ehu.eus, 34489@debbugs.gnu.org > > > [1:text/plain Hide] > > Eli Zaretskii writes: > > > Hmm... I wonder why the code bothers specifying the allowed characters > > explicitly, and in particular why it only allows ASCII characters. > > > > Does the code work if the directory has non-ASCII characters instead > > of "++"? > > No, it breaks. For now, I've attached a patch to use "[:alnum:]", > which fixes that use case for me. > > Regarding your first question, I'm not exactly sure why. Maybe we > could go as far as just doing "[[:print:]]*" for that part - or > simply ".*". What do you think? I think both [:print:] and .* would be too radical, as I'm not sure including control characters and arbitrary whitespace will not break something. But maybe [:graph:] is better than [:alnum:]. In any case, I think we want a comment there saying that this is to allow more characters in file names shown in the prompt. Thanks.