From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: a.soroa@ehu.eus, 34489@debbugs.gnu.org
Subject: bug#34489: 25.2; pdb fails if directory contains '++'
Date: Wed, 03 Jul 2019 08:39:19 +0300 [thread overview]
Message-ID: <83h883d6d4.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmkGZkqyhqDoDRrA9pXXy1OxrhQgP6=pS68JHe30__6frQ@mail.gmail.com> (message from Stefan Kangas on Tue, 2 Jul 2019 21:42:31 +0200)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 2 Jul 2019 21:42:31 +0200
> Cc: a.soroa@ehu.eus, 34489@debbugs.gnu.org
>
>
> [1:text/plain Hide]
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Hmm... I wonder why the code bothers specifying the allowed characters
> > explicitly, and in particular why it only allows ASCII characters.
> >
> > Does the code work if the directory has non-ASCII characters instead
> > of "++"?
>
> No, it breaks. For now, I've attached a patch to use "[:alnum:]",
> which fixes that use case for me.
>
> Regarding your first question, I'm not exactly sure why. Maybe we
> could go as far as just doing "[[:print:]]*" for that part - or
> simply ".*". What do you think?
I think both [:print:] and .* would be too radical, as I'm not sure
including control characters and arbitrary whitespace will not break
something. But maybe [:graph:] is better than [:alnum:].
In any case, I think we want a comment there saying that this is to
allow more characters in file names shown in the prompt.
Thanks.
next prev parent reply other threads:[~2019-07-03 5:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 8:32 bug#34489: 25.2; pdb fails if directory contains '++' a.soroa
2019-06-30 16:13 ` Stefan Kangas
2019-06-30 16:33 ` Eli Zaretskii
2019-06-30 17:24 ` Stefan Kangas
2019-07-02 16:35 ` Eli Zaretskii
2019-07-02 19:42 ` Stefan Kangas
2019-07-03 5:39 ` Eli Zaretskii [this message]
2019-07-05 15:51 ` Stefan Kangas
2019-07-06 9:10 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h883d6d4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34489@debbugs.gnu.org \
--cc=a.soroa@ehu.eus \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.