From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24050: 24.5; ispell-change-dictionary suggests non-existent dicts (aspell) Date: Sun, 28 Jul 2019 17:17:22 +0300 Message-ID: <83h876kzv1.fsf@gnu.org> References: <87k1c2cv77.fsf@mouse.gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="155506"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 24050@debbugs.gnu.org, olejorgenb@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 16:18:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrk01-000eLO-Fi for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 16:18:09 +0200 Original-Received: from localhost ([::1]:45428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrk00-0001eN-Fy for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 10:18:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42833) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrjzv-0001eD-N0 for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:18:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrjzu-00085d-OA for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38114) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrjzu-00085N-Kr for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrjzu-0001WZ-Dd for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2019 14:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24050 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 24050-submit@debbugs.gnu.org id=B24050.15643234675833 (code B ref 24050); Sun, 28 Jul 2019 14:18:02 +0000 Original-Received: (at 24050) by debbugs.gnu.org; 28 Jul 2019 14:17:47 +0000 Original-Received: from localhost ([127.0.0.1]:46935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrjzf-0001W1-0P for submit@debbugs.gnu.org; Sun, 28 Jul 2019 10:17:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrjzc-0001Vo-CO for 24050@debbugs.gnu.org; Sun, 28 Jul 2019 10:17:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hrjzW-0006YY-Uz; Sun, 28 Jul 2019 10:17:38 -0400 Original-Received: from [176.228.60.248] (port=3346 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hrjzW-0004a8-E8; Sun, 28 Jul 2019 10:17:38 -0400 In-reply-to: <87k1c2cv77.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Sun, 28 Jul 2019 12:25:16 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163960 Archived-At: > From: Lars Ingebrigtsen > Date: Sun, 28 Jul 2019 12:25:16 +0200 > Cc: 24050@debbugs.gnu.org > > Thanks for the analysis; altering the code along these lines does fix > the problem, and `M-x ispell-change-dictionary' now seems a lot more > useful now that it just lists the dictionaries I actually have > installed. > > > I would suggest simply removing [1] and not add the *base-alist above when using > > aspell/hunspell, but the following comment makes it seem like the "invalid" > > entries are added intentionally: > > > > ;; Substitute ispell-dictionary-alist with the list of > > ;; dictionaries corresponding to the given spellchecker. > > ;; If a recent aspell or hunspell, use the list of really > > ;; installed dictionaries and add to it elements of the original > > ;; list that are not present there*. Allow distro info. > > It may be intentional, but the other comments seem to indicate that it's > not... and I don't see the utility of listing dictionaries we don't > have, so I think it's a good change anyway. > > So I've made it on the Emacs trunk now. I think this is a mistake, and should be reverted. It prevents users from telling ispell.el to switch to a dictionary that aspell/hunspell didn't return in the list. That's a regression. The OP's suggestion would make sense if the list created by that function was only used for completion. However, in fact we also force the user to specify a dictionary from the list, i.e. the selection must match one of the members of the list. So this change is for the worse.