From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36858: 27.0.50; display bugs with display-fill-column-indicator-mode Date: Wed, 07 Aug 2019 19:37:04 +0300 Message-ID: <83h86taq4v.fsf@gnu.org> References: <83wofwexkr.fsf@gnu.org> <20190805152747.4vyzejqoiy33l4ou@Ergus> <83tvatavmh.fsf@gnu.org> <20190807162033.hpphf2pbfo4p6vam@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="211103"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36858@debbugs.gnu.org, rotim.davor@gmail.com To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 07 18:38:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hvOwz-000smk-AS for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 18:38:09 +0200 Original-Received: from localhost ([::1]:43484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvOwx-0001Nk-Pz for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 12:38:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44510) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvOwt-0001Nb-M5 for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 12:38:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvOws-0006S1-Pj for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 12:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58700) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvOws-0006Rx-MJ for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 12:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hvOws-0002QP-IL for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 12:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Aug 2019 16:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36858 X-GNU-PR-Package: emacs Original-Received: via spool by 36858-submit@debbugs.gnu.org id=B36858.15651958439257 (code B ref 36858); Wed, 07 Aug 2019 16:38:02 +0000 Original-Received: (at 36858) by debbugs.gnu.org; 7 Aug 2019 16:37:23 +0000 Original-Received: from localhost ([127.0.0.1]:39288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvOwF-0002PF-F7 for submit@debbugs.gnu.org; Wed, 07 Aug 2019 12:37:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvOwD-0002P2-5k for 36858@debbugs.gnu.org; Wed, 07 Aug 2019 12:37:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hvOw8-0005CD-00; Wed, 07 Aug 2019 12:37:16 -0400 Original-Received: from [176.228.60.248] (port=1728 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hvOw6-0005DY-TA; Wed, 07 Aug 2019 12:37:15 -0400 In-reply-to: <20190807162033.hpphf2pbfo4p6vam@Ergus> (message from Ergus on Wed, 7 Aug 2019 18:20:33 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164724 Archived-At: > Date: Wed, 7 Aug 2019 18:20:33 +0200 > From: Ergus > Cc: 36858@debbugs.gnu.org, rotim.davor@gmail.com > > in this code (in xdisp.c): > > if (it->current_x < indicator_column_x) > { > it->face_id = merge_faces (it->w, Qextend_to_end_of_line, > 0, extend_face_merged_id); > > it->char_to_display = XFIXNAT (Vdisplay_fill_column_indicator_character); > PRODUCE_GLYPHS (it); > > it->face_id = extend_face_merged_id; > } > > I changed char_to_display: > > it->char_to_display = (it->glyph_row->ends_at_zv_p) ? '1' : '0'; (There's no need to make any changes for that, you can simply invoke dump-glyph-row or dump-glyph-matrix.) > And then I obtained the attached image. Right, I forgot where in the code we set that flag, and display of an after-string at EOB indeed happens before that. But since Dmitry says the case of Company mode doesn't need to be fixed, I think this is a moot point now. We should only solve the issue with attributes being extended all the way towards the indicator column. Thanks.