From: Eli Zaretskii <eliz@gnu.org>
To: Ergus <spacibba@aol.com>
Cc: 36858@debbugs.gnu.org, rotim.davor@gmail.com
Subject: bug#36858: 27.0.50; display bugs with display-fill-column-indicator-mode
Date: Wed, 07 Aug 2019 19:37:04 +0300 [thread overview]
Message-ID: <83h86taq4v.fsf@gnu.org> (raw)
In-Reply-To: <20190807162033.hpphf2pbfo4p6vam@Ergus> (message from Ergus on Wed, 7 Aug 2019 18:20:33 +0200)
> Date: Wed, 7 Aug 2019 18:20:33 +0200
> From: Ergus <spacibba@aol.com>
> Cc: 36858@debbugs.gnu.org, rotim.davor@gmail.com
>
> in this code (in xdisp.c):
>
> if (it->current_x < indicator_column_x)
> {
> it->face_id = merge_faces (it->w, Qextend_to_end_of_line,
> 0, extend_face_merged_id);
>
> it->char_to_display = XFIXNAT (Vdisplay_fill_column_indicator_character);
> PRODUCE_GLYPHS (it);
>
> it->face_id = extend_face_merged_id;
> }
>
> I changed char_to_display:
>
> it->char_to_display = (it->glyph_row->ends_at_zv_p) ? '1' : '0';
(There's no need to make any changes for that, you can simply invoke
dump-glyph-row or dump-glyph-matrix.)
> And then I obtained the attached image.
Right, I forgot where in the code we set that flag, and display of an
after-string at EOB indeed happens before that.
But since Dmitry says the case of Company mode doesn't need to be
fixed, I think this is a moot point now. We should only solve the
issue with attributes being extended all the way towards the indicator
column.
Thanks.
next prev parent reply other threads:[~2019-08-07 16:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 18:11 bug#36858: 27.0.50; display bugs with display-fill-column-indicator-mode Davor Rotim
2019-08-02 9:16 ` Eli Zaretskii
2019-08-02 10:25 ` Ergus
2019-08-02 11:53 ` Eli Zaretskii
2019-08-05 23:54 ` Ergus
2019-08-05 15:27 ` Ergus
2019-08-07 14:38 ` Eli Zaretskii
2019-08-07 16:20 ` Ergus
2019-08-07 16:37 ` Eli Zaretskii [this message]
2019-08-07 17:06 ` Ergus
2019-08-07 17:29 ` Eli Zaretskii
2019-08-07 19:46 ` Ergus
2019-08-08 7:17 ` Ergus
2019-08-08 17:33 ` Eli Zaretskii
2019-08-08 22:29 ` Ergus
2019-08-08 17:31 ` Eli Zaretskii
2019-08-08 22:32 ` Ergus
2019-08-06 10:44 ` Dmitry Gutov
2019-08-10 8:22 ` Eli Zaretskii
2019-08-10 8:35 ` Davor Rotim
2019-08-10 9:58 ` Eli Zaretskii
2019-08-10 10:12 ` Davor Rotim
2019-08-10 10:45 ` Eli Zaretskii
2019-08-10 11:53 ` Eli Zaretskii
2019-08-10 13:21 ` Carsten Dominik
2019-08-10 13:38 ` Eli Zaretskii
2019-08-10 14:17 ` Carsten Dominik
2019-08-10 14:41 ` Eli Zaretskii
2019-08-12 7:10 ` Carsten Dominik
2019-08-12 14:26 ` Eli Zaretskii
2019-08-10 18:02 ` Ergus
2019-10-20 22:12 ` bug#36858: (no subject) Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] <<CAMWA6ANTAsSz4ckRGSTuVRCHJKZMDEd1SsBaJetW3bWRjPTRNQ@mail.gmail.com>
[not found] ` <<83zhkh8m5n.fsf@gnu.org>
[not found] ` <<CAMWA6AMvD5Vt=fDcHjufcrVUPy__tQ00tk9aobYjyrgoaSiF=w@mail.gmail.com>
[not found] ` <<83mugh8hqg.fsf@gnu.org>
[not found] ` <<CAMWA6ANXJvdCptHYV_qzXuwtfdoXM3Ygo577gPorgLRD1EQAJw@mail.gmail.com>
[not found] ` <<83imr58fji.fsf@gnu.org>
[not found] ` <<83d0hd8ceh.fsf@gnu.org>
[not found] ` <<CADn3Z2Ke4S+BCaniLWYxT3Vf6-gqt-oHCqcHj6rz22tG0ntw8g@mail.gmail.com>
[not found] ` <<83a7ch87j8.fsf@gnu.org>
2019-08-10 16:15 ` bug#36858: 27.0.50; display bugs with display-fill-column-indicator-mode Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h86taq4v.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36858@debbugs.gnu.org \
--cc=rotim.davor@gmail.com \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.