From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37006: 27.0.50; garbage collection not happening after 26de2d42 Date: Tue, 13 Aug 2019 18:37:42 +0300 Message-ID: <83h86lrs8p.fsf@gnu.org> References: <5075406D-6DB8-4560-BB64-7198526FCF9F@acm.org> <83h86nu0pq.fsf@gnu.org> <86pnlbphus.fsf@phe.ftfl.ca> <83a7cft8qx.fsf@gnu.org> <868srysb9x.fsf@phe.ftfl.ca> <83wofis508.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="114242"; mail-complaints-to="usenet@blaine.gmane.org" Cc: jrm@ftfl.ca, eggert@cs.ucla.edu, 37006@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 13 17:39:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hxYtB-000Tb6-Er for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Aug 2019 17:39:09 +0200 Original-Received: from localhost ([::1]:53512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxYtA-0001gj-Ge for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Aug 2019 11:39:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51082) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxYt6-0001gb-7u for bug-gnu-emacs@gnu.org; Tue, 13 Aug 2019 11:39:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxYt5-0004c6-BW for bug-gnu-emacs@gnu.org; Tue, 13 Aug 2019 11:39:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39747) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hxYt5-0004bx-8B for bug-gnu-emacs@gnu.org; Tue, 13 Aug 2019 11:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hxYt4-0000CG-Vs for bug-gnu-emacs@gnu.org; Tue, 13 Aug 2019 11:39:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Aug 2019 15:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37006 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37006-submit@debbugs.gnu.org id=B37006.1565710683684 (code B ref 37006); Tue, 13 Aug 2019 15:39:02 +0000 Original-Received: (at 37006) by debbugs.gnu.org; 13 Aug 2019 15:38:03 +0000 Original-Received: from localhost ([127.0.0.1]:48568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hxYs7-0000Ay-3W for submit@debbugs.gnu.org; Tue, 13 Aug 2019 11:38:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hxYs5-0000AI-DL for 37006@debbugs.gnu.org; Tue, 13 Aug 2019 11:38:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hxYrz-0003sj-J5; Tue, 13 Aug 2019 11:37:55 -0400 Original-Received: from [176.228.60.248] (port=1323 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hxYry-0007pt-Vf; Tue, 13 Aug 2019 11:37:55 -0400 In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 12 Aug 2019 19:00:37 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164937 Archived-At: > From: Mattias Engdegård > Date: Mon, 12 Aug 2019 19:00:37 +0200 > Cc: Joseph Mingrone , Paul Eggert , > 37006@debbugs.gnu.org > > What about biasing consing_until_gc by gc_cons_threshold, and change the condition in maybe_gc to (the moral equivalent of) > > if (consing_until_gc < gc_cons_threshold) > > ? It is practically as cheap as the current test against 0. Yes, but the full calculation of the threshold is more complicated than that. For starters, how do you handle gc_cons_threshold values that are smaller than GC_DEFAULT_THRESHOLD / 10 under your proposal? There are use cases where the value was below that before and is above now, or the other way around, or was below and stays below. And that's even before we consider other complications: when memory-full is non-nil, we should use a different threshold; and what about user changes to gc-cons-percentage?