From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 36156@debbugs.gnu.org, juri@linkov.net
Subject: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips
Date: Sun, 25 Aug 2019 14:46:22 +0300 [thread overview]
Message-ID: <83h865h3ht.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmKdpFNDqFHBF4R8H_0Y1hRO3RQKv2i0X81yO-5ygnkMQ@mail.gmail.com> (message from Stefan Kangas on Sun, 25 Aug 2019 13:03:06 +0200)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Sun, 25 Aug 2019 13:03:06 +0200
> Cc: 36156@debbugs.gnu.org
>
> Juri Linkov <juri@linkov.net> writes:
>
> > Today I found a regression in this change: when a tool-bar item
> > doesn't use a :help keyword (like e.g. in gud-menu-map) then
> > the tooltip displays just keyboard equivalents in its tooltip.
> > It used to display the caption in previous Emacs versions.
> > I believe it could be fixed by this patch:
>
> I can reproduce this regression in the gud toolbar on current master.
> Your patch fixes it and looks good to me.
Are we sure TOOL_BAR_ITEM_CAPTION will always produce human-readable
text?
next prev parent reply other threads:[~2019-08-25 11:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 1:14 bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips Stefan Kangas
2019-06-10 2:06 ` Noam Postavsky
2019-06-10 3:30 ` Stefan Kangas
2019-06-10 16:54 ` Eli Zaretskii
2019-06-11 21:28 ` Stefan Kangas
2019-06-22 9:13 ` Eli Zaretskii
2019-08-24 20:40 ` Juri Linkov
2019-08-25 11:03 ` Stefan Kangas
2019-08-25 11:46 ` Eli Zaretskii [this message]
2019-08-25 12:58 ` Stefan Kangas
2019-08-25 13:10 ` Eli Zaretskii
2019-08-25 20:18 ` Juri Linkov
2019-08-26 6:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h865h3ht.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36156@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.