Re: Master fails to build on Windows

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri, 1 Nov 2019 19:11:22 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: emacs-devel@gnu.org
> 
> No no, my script (emacs-w64-build.sh) downloads the source, run autogen.sh and
> 
> eval "${emacs_build_env}" ./configure --prefix="/${PREFIXNAME}" \
>          --build=x86_64-w64-mingw32 \
>          --without-imagemagick \
>          --without-dbus \
>          --without-pop \
>          --with-modules
> 
> make ${MAKE_OPT}
> 
> where 
> 
> emacs_build_env is, basically,
> 
>   CPPFLAGS="-D_FORTIFY_SOURCE=2 -D__USE_MINGW_ANSI_STDIO=1" \
>   CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe"

Why are you using non-default compiler flags?  Are they really needed,
or is this just a copy/paste from MSYS2?  If the latter, can I
convince not to use the MSYS2 options?  They are in many cases
incorrect or suboptimal.

In any case, you should definitely report the non-default settings
when you describe any problems, because these options can have
significant effect on the binary.

> The script 'makepkg-mingw' belongs to MSYS2 installation. If you remember, MSYS2 uses PKGBUILD scripts as in ArchLinux and 'makepkg-mingw' is used to build MinGW packages (there is also a 'makepkg' script to build _native_ MSYS2 packages). See https://github.com/msys2/msys2/wiki/Creating-packages#building.

I know about their scripts, I just don't understand why you would want
to use them.  You aren't building an MSYS2 Emacs, you are building
Emacs for yourself, right?