From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <ghe@sdf.org>, Alex Branham <alex.branham@gmail.com>
Cc: 42383@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#42383: 28.0.50; Two bugs with M-x compile
Date: Thu, 16 Jul 2020 18:17:28 +0300 [thread overview]
Message-ID: <83h7u7lcaf.fsf@gnu.org> (raw)
In-Reply-To: <alpine.NEB.2.21.2007161131410394.27838@sdf.lonestar.org> (bug-gnu-emacs@gnu.org)
> Date: Thu, 16 Jul 2020 09:48:56 +0000
> From: Gregory Heytings via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
>
> > 1. create a Makefile with a few targets
> > 2. start emacs -Q
> > 3. M-x compile
> > 4. press TAB: the list of targets is displayed
> > 5. type the first character of an existing target, and press TAB
> > 6. the result is a "[No match]"
> >
> > This has been working correctly for years (tested with Emacs 24, 25,
> > 26), and does not work anymore with Emacs 28.
> >
> > It seems that at step 5 above the list of completion candidates that is
> > considered are subdirectories.
> >
>
> Upon further investigation, this bug has been introduced by the patch for
> bug#34330, which moved pcomplete-completions-at-point last in
> shell-dynamic-complete-functions in shell.el:
>
> (defcustom shell-dynamic-complete-functions
> '(comint-c-a-p-replace-by-expanded-history
> shell-environment-variable-completion
> shell-command-completion
> shell-c-a-p-replace-by-expanded-directory
> shell-filename-completion
> comint-filename-completion
> ;; Put `pcomplete-completions-at-point' last so that other
> ;; functions can run before it does, see bug#34330.
> pcomplete-completions-at-point)
>
> See https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e4d17d8cb479ffeeb7dfb7320a1432722ac8df75 .
>
> The obvious fix is to revert the situation (that is, to move
> pcomplete-completions-at-point again before shell-filename-completion),
> but I'm not sure, because bug#34330 would again exist. That being said,
> I'm not sure that handling the exceptional case of filenames with '&'
> characters correctly when completing in M-x shell (which is what bug#34330
> is about) justifies to break normal behavior in other situations.
Indeed.
Stefan, Alex: any ideas for how to fix this? This problem exists on
the emacs-27 branch, so we must find a safe solution for that branch,
and we must do that quickly. If we don't have any better ideas, I
think we should revert that fix on emacs-27 at least.
Thanks.
next prev parent reply other threads:[~2020-07-16 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 23:23 bug#42383: 28.0.50; Two bugs with M-x compile Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-16 9:48 ` Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-16 15:17 ` Eli Zaretskii [this message]
2020-07-16 18:55 ` Stefan Monnier
2020-07-16 21:39 ` Alex Branham
2020-07-16 22:37 ` Stefan Monnier
2020-07-18 8:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h7u7lcaf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=42383@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
--cc=ghe@sdf.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.