From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43117: [PATCH] Add .git-blame-ignore-revs file Date: Sun, 13 Sep 2020 20:34:10 +0300 Message-ID: <83h7s1bmy5.fsf@gnu.org> References: <197409406.192953.1598809591346@ichabod.co-bxl> <9aa79095-18d6-d0bd-18ad-aa5d90f0bb1d@yandex.ru> <1898378843.430816.1599957743795@ichabod.co-bxl> <83bli9db3t.fsf@gnu.org> <1670898213.459425.1600016799389@ichabod.co-bxl> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8397"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, dgutov@yandex.ru, 43117@debbugs.gnu.org To: Brian Leung Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 13 19:35:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHVuA-00024R-S2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 19:35:10 +0200 Original-Received: from localhost ([::1]:44922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHVu9-00064k-T6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 13:35:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHVu2-00064D-Se for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 13:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40090) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHVu2-0003aX-J7 for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 13:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHVu2-0006uD-GC for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 13:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Sep 2020 17:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43117-submit@debbugs.gnu.org id=B43117.160001847026504 (code B ref 43117); Sun, 13 Sep 2020 17:35:02 +0000 Original-Received: (at 43117) by debbugs.gnu.org; 13 Sep 2020 17:34:30 +0000 Original-Received: from localhost ([127.0.0.1]:51636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHVtH-0006tB-Ny for submit@debbugs.gnu.org; Sun, 13 Sep 2020 13:34:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHVtG-0006sz-58 for 43117@debbugs.gnu.org; Sun, 13 Sep 2020 13:34:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33569) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHVtA-0003SR-1i; Sun, 13 Sep 2020 13:34:08 -0400 Original-Received: from [176.228.60.248] (port=3281 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kHVt9-0001tz-GG; Sun, 13 Sep 2020 13:34:07 -0400 In-Reply-To: <1670898213.459425.1600016799389@ichabod.co-bxl> (message from Brian Leung on Sun, 13 Sep 2020 19:06:39 +0200 (CEST)) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187992 Archived-At: > Date: Sun, 13 Sep 2020 19:06:39 +0200 (CEST) > From: Brian Leung > Cc: dgutov@yandex.ru, rpluim@gmail.com, 43117@debbugs.gnu.org > > > I'm not sure I understand the rationale: why would we want to replace > > all 'if's with 'when's? > > I expected that people would find it easier to read 'when'/'unless' than single-clause 'if' statements. The 'when'/'unless', along with the indentation of the corresponding 'then' clause, immediately signal that there is only one possible non-nil form returned. With single-clause 'if' statements, you would have to continue reading past the 'then' clause to spot what the 'when'/'unless' and its differing indentation immediately tell you. To go over two dozen of files and summarily replace 'if' with 'when' for this reason sounds way too radical to me. I have no difficulties understanding the original code, FWIW. Is it just me? do others think such changes are a good idea?