From: Eli Zaretskii <eliz@gnu.org>
To: Vasilij Schneidermann <mail@vasilij.de>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Dealing with obsoletion warnings in non-core code
Date: Mon, 28 Sep 2020 22:00:22 +0300 [thread overview]
Message-ID: <83h7rhloah.fsf@gnu.org> (raw)
In-Reply-To: <20200928183457.GC1002@odonien.localdomain> (message from Vasilij Schneidermann on Mon, 28 Sep 2020 20:34:57 +0200)
> Date: Mon, 28 Sep 2020 20:34:57 +0200
> From: Vasilij Schneidermann <mail@vasilij.de>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
>
> > (if (> emacs-major-version NN)
> > (defun recommended-function (...)
> > ...))
>
> You don't want a third-party package defining a potentially
> non-conformant version of future built-in functionality
We've been using such shims in packages that supported both Emacs and
XEmacs, for eons. I don't see how it's suddenly so wrong.
> (for example if they take the definition from a specific Emacs
> version and it changes in another one)
That's a separate problem, and will happen even if you only support
versions where the function is available. It's why we try very hard
not to make backward-incompatible changes in public APIs.
> Besides, isn't the logic the wrong way around? The recommended function
> is something available in a newer Emacs version, so you'd test for an
> older one and if the check is positive, define the shim.
You assume that the older one is removed? That usually doesn't
happen.
> Assuming you can even, some functionality cannot be backported that
> easily.
If the functionality cannot be had at all, there's no problem: just
provide a no-op function by that name.
Anyway, you asked how to avoid warning messages, and I suggested a way
which should do that. If that's not what you want, fine; I tried to
help you.
next prev parent reply other threads:[~2020-09-28 19:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 14:35 Dealing with obsoletion warnings in non-core code Vasilij Schneidermann
2020-09-28 17:32 ` Stefan Monnier
2020-09-28 18:16 ` Eli Zaretskii
2020-09-28 18:34 ` Vasilij Schneidermann
2020-09-28 19:00 ` Eli Zaretskii [this message]
2020-09-28 19:24 ` Stefan Monnier
2020-09-29 14:07 ` Eli Zaretskii
2020-09-29 8:21 ` Gregory Heytings via Emacs development discussions.
2020-09-29 8:28 ` Gregory Heytings via Emacs development discussions.
2020-09-29 9:33 ` Gregory Heytings via Emacs development discussions.
2020-09-29 13:11 ` Stefan Monnier
2020-09-29 14:11 ` Gregory Heytings via Emacs development discussions.
2020-09-29 14:46 ` Stefan Monnier
2020-09-29 15:36 ` Gregory Heytings via Emacs development discussions.
2020-09-29 14:55 ` T.V Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h7rhloah.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mail@vasilij.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.