From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Little improvements on pulse.el
Date: Wed, 10 Mar 2021 21:11:28 +0200
Message-ID: <83h7liomcf.fsf@gnu.org>
References: <CH2PR01MB5879637707F4A54A1418825F8B919@CH2PR01MB5879.prod.exchangelabs.com>
 <83ft13p5ow.fsf@gnu.org>
 <CADwFkmnp3UUMcJb+uT7-XJ6AgUodDfGJTUx-Q8kdjVmF-t+NrA@mail.gmail.com>
 <87tupjort6.fsf@mail.linkov.net> <87mtvan8oi.fsf@mail.linkov.net>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="37204"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: gabriel376@hotmail.com, stefankangas@gmail.com, emacs-devel@gnu.org
To: Juri Linkov <juri@linkov.net>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 10 20:18:06 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lK4LO-0009Xe-NX
	for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Mar 2021 20:18:06 +0100
Original-Received: from localhost ([::1]:41042 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lK4LN-0002j4-NX
	for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Mar 2021 14:18:05 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42832)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lK4F3-0007ZV-8c
 for emacs-devel@gnu.org; Wed, 10 Mar 2021 14:11:33 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40403)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lK4F2-0006L0-N4; Wed, 10 Mar 2021 14:11:32 -0500
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4420
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lK4F2-0008GF-0p; Wed, 10 Mar 2021 14:11:32 -0500
In-Reply-To: <87mtvan8oi.fsf@mail.linkov.net> (message from Juri Linkov on
 Wed, 10 Mar 2021 20:51:57 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:266295
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/266295>

> From: Juri Linkov <juri@linkov.net>
> Cc: Gabriel <gabriel376@hotmail.com>,  Eli Zaretskii <eliz@gnu.org>,
>   emacs-devel@gnu.org
> Date: Wed, 10 Mar 2021 20:51:57 +0200
> 
> BTW, currently 'pulse-momentary-highlight-one-line'
> has no visible indication on an empty line, so it's face
> should be fixed to have the face attribute :extend t.

I disagree with doing this unconditionally.  Current uses of this face
don't need to show empty lines, so adding that attribute would
gratuitously change previous behavior.

Commands that want to use this for potentially empty lines can always
produce a derived face if they so want.