[PATCH] Autoload list-colors-display

[PATCH] Autoload list-colors-display

[Gregory Heytings]

[-- Attachment #1: Type: text/plain, Size: 135 bytes --]


Facemenu is not preloaded anymore, but the manual (info "(emacs)Colors for 
Faces") mentions M-x list-colors-display.  Patch attached.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff; name=0001-Autoload-list-colors-display.patch, Size: 936 bytes --]

From b2717eae8e801dcddbcb8f605a59509ae1e0a8de Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Sat, 10 Apr 2021 12:35:06 +0000
Subject: [PATCH] Autoload list-colors-display.

* lisp/facemenu.el (list-colors-display): Autoload, it is mentioned
in (info "(emacs)Colors for Faces").
---
 lisp/facemenu.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/facemenu.el b/lisp/facemenu.el
index 2d06658b55..8db1b42db4 100644
--- a/lisp/facemenu.el
+++ b/lisp/facemenu.el
@@ -539,6 +539,7 @@ list-colors-redisplay
 This is installed as a `revert-buffer-function' in the *Colors* buffer."
   (list-colors-display nil (buffer-name) list-colors-callback))
 
+;;;###autoload
 (defun list-colors-display (&optional list buffer-name callback)
   "Display names of defined colors, and show what they look like.
 If the optional argument LIST is non-nil, it should be a list of
-- 
2.30.2

Re: [PATCH] Autoload list-colors-display

[Eli Zaretskii]

> Date: Sat, 10 Apr 2021 12:43:52 +0000
> From: Gregory Heytings <gregory@heytings.org>
> 
> Facemenu is not preloaded anymore, but the manual (info "(emacs)Colors for 
> Faces") mentions M-x list-colors-display.  Patch attached.

Thanks, installed.

Btw, we generally prefer that patches are sent to the bug tracker, as
that allows more easily to find the relevant discussions.

Re: [PATCH] Autoload list-colors-display

[Gregory Heytings]

>
> Thanks, installed.
>

Thanks.

>
> Btw, we generally prefer that patches are sent to the bug tracker, as 
> that allows more easily to find the relevant discussions.
>

I admit I don't clearly see the difference between emacs-devel and 
bug-gnu-emacs.  What's the rule?  patch => bug-gnu-emacs, general 
discussion => emacs-devel?  But then things like the improved 
help-for-help would not be seen on emacs-devel.  And opening a bug report 
for a small change doesn't seem right (to me).

Re: [PATCH] Autoload list-colors-display

[Eli Zaretskii]

> Date: Sat, 10 Apr 2021 13:26:10 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: emacs-devel@gnu.org
> 
> What's the rule?  patch => bug-gnu-emacs, general discussion =>
> emacs-devel?

In general, yes.

> But then things like the improved help-for-help would not be seen on
> emacs-devel.  And opening a bug report for a small change doesn't
> seem right (to me).

They aren't hard rules.  I said "we generally prefer", and I meant
every word of it.  Use your judgment; and in any case it isn't a
catastrophe if it ends up in the other place.