From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22763: 25.1.50; Feature Request -- A faster method to obtain line number at position. Date: Thu, 20 May 2021 23:09:58 +0300 Message-ID: <83h7ixnp49.fsf@gnu.org> References: <1TyanmjF6SBvziMpm9jWhwA0kDQ9iG5jzO7S0dTBDQjNe1sc7te_PrVSR1_pGXPFgQzlDEX2Nq5NK-wJiHQyCDhemaevOVf527K_I1jGvIw=@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6307"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 22763@debbugs.gnu.org To: Ben Levy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 20 22:11:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljp0g-0001Of-P0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 22:11:10 +0200 Original-Received: from localhost ([::1]:47642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljp0f-0007K8-Nl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 16:11:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljp0Y-0007Ip-MU for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 16:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51947) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljp0Y-0003oG-FN for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 16:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ljp0Y-0002Q7-90 for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 16:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 May 2021 20:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22763-submit@debbugs.gnu.org id=B22763.16215414119217 (code B ref 22763); Thu, 20 May 2021 20:11:02 +0000 Original-Received: (at 22763) by debbugs.gnu.org; 20 May 2021 20:10:11 +0000 Original-Received: from localhost ([127.0.0.1]:35259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljozj-0002Ob-G0 for submit@debbugs.gnu.org; Thu, 20 May 2021 16:10:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljozg-0002OH-QY for 22763@debbugs.gnu.org; Thu, 20 May 2021 16:10:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45168) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljozb-0003AY-Cx; Thu, 20 May 2021 16:10:03 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1219 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljoza-0005Gx-Hh; Thu, 20 May 2021 16:10:03 -0400 In-Reply-To: <1TyanmjF6SBvziMpm9jWhwA0kDQ9iG5jzO7S0dTBDQjNe1sc7te_PrVSR1_pGXPFgQzlDEX2Nq5NK-wJiHQyCDhemaevOVf527K_I1jGvIw=@protonmail.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206962 Archived-At: > Date: Thu, 20 May 2021 19:53:24 +0000 > From: Ben Levy via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I'm not 100% sure about this, but it looks like when > line-number-at-pos was written in elisp, it didn't do > any bounds check, and instead called (widen) before > counting lines. Did the elisp version have unintended > behavior, or are the differences with the C version > a regression? I cannot answer that, because I don't understand what regression are you talking about. There's no need to widen the buffer in order to scan buffer text in C, AFAIK. > I think it's causing this bug: > https://github.com/io12/good-scroll.el/issues/16 Please explain the connection. I've read that discussion, but didn't see any data that would indicate this function is the culprit. At the very least, please tell which arguments are passed to line-number-at-pos in the problematic case, and what is the narrowed region.