From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 49624@debbugs.gnu.org, monnier@iro.umontreal.ca, juri@linkov.net
Subject: bug#49624: compilation message end-column function off-by-one bug
Date: Sun, 18 Jul 2021 22:10:05 +0300 [thread overview]
Message-ID: <83h7gr781e.fsf@gnu.org> (raw)
In-Reply-To: <462A3B1B-6632-4740-907D-03B67377452E@acm.org> (message from Mattias Engdegård on Sun, 18 Jul 2021 21:00:41 +0200)
> From: Mattias Engdegård <mattiase@acm.org>
> Date: Sun, 18 Jul 2021 21:00:41 +0200
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, Juri Linkov <juri@linkov.net>
>
> Compilation message patterns (in compilation-regexp-alist and -alist) can indicate starting and ending line and column numbers, either by supplying regexp match numbers or functions that return the respective line/column numbers when called. In other words, the integer N can be understood as a shorthand for the function
>
> (lambda () (and (match-beginning N) (string-to-number (match-string N))))
>
> except that isn't true for the ending column where there is a difference of 1; an END-COL function returning 13 means that the error's last column is 12.
Isn't that because END-COL is the first column _beyond_ the last
column?
next prev parent reply other threads:[~2021-07-18 19:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 19:00 bug#49624: compilation message end-column function off-by-one bug Mattias Engdegård
2021-07-18 19:10 ` Eli Zaretskii [this message]
2021-07-18 19:13 ` Mattias Engdegård
2021-07-18 19:30 ` Eli Zaretskii
2021-07-19 10:39 ` Mattias Engdegård
[not found] ` <875yx6qtwg.fsf@mail.linkov.net>
[not found] ` <5BAAD7D4-A578-4DB5-925E-ECE02B4F4B56@acm.org>
[not found] ` <87pmvevv28.fsf@mail.linkov.net>
2021-07-23 13:24 ` Mattias Engdegård
2021-07-26 17:06 ` Juri Linkov
2021-07-26 19:30 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h7gr781e.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=49624@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.