From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Native compiler - passing command line options to C compiler Date: Mon, 30 Aug 2021 19:01:17 +0300 Message-ID: <83h7f6kjle.fsf@gnu.org> References: <83bl5fkvky.fsf@gnu.org> <83v93njc3x.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16325"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, akrl@sdf.org To: Arthur Miller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 30 18:04:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKjlT-0003uY-EA for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Aug 2021 18:04:03 +0200 Original-Received: from localhost ([::1]:53904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKjlR-0008Kv-MV for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Aug 2021 12:04:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKjj2-0005QW-55 for emacs-devel@gnu.org; Mon, 30 Aug 2021 12:01:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51828) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKjj0-0002Nj-Ew; Mon, 30 Aug 2021 12:01:30 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3208 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKjiy-0007ug-6A; Mon, 30 Aug 2021 12:01:30 -0400 In-Reply-To: (message from Arthur Miller on Mon, 30 Aug 2021 17:00:08 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273511 Archived-At: > From: Arthur Miller > Cc: Eli Zaretskii , emacs-devel@gnu.org > Date: Mon, 30 Aug 2021 17:00:08 +0200 > > So does that mean that windows check is not needed in add_driver_options as well? I wouldn't delete it from there. On Windows, we assume without checking that gcc_jit_context_add_command_line_option exists, because (a) Windows versions of libgccjit appeared only in GCC versions that already supported that, and (b) without that native-compilation could produce code that crashes on Windows. IOW, this is an internal implementation detail, a workaround for a nasty problem. But for a general-purpose text that will cause no disaster if it fails, I'd like not to use tricky conditionals that need long explanations.