From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2ed2999: Improve documentation of new Xref options Date: Tue, 07 Sep 2021 16:05:47 +0300 Message-ID: <83h7ewpmc4.fsf@gnu.org> References: <20210905075953.20536.20920@vcs0.savannah.gnu.org> <20210905075955.0F6B720A0A@vcs0.savannah.gnu.org> <6f1fcbee-1825-1219-88fb-e6f28d00ab4d@yandex.ru> <831r62tjf3.fsf@gnu.org> <0eaa7dc7-a3f2-5319-bf09-629f9949e416@yandex.ru> <834kaxsxb8.fsf@gnu.org> <7fe2eafb-e15a-beab-f485-9c80b2913121@yandex.ru> <831r61soqu.fsf@gnu.org> <6c33d3c8-5155-f0fe-ec47-0630d9f3525f@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34088"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 07 15:24:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNb5k-0008eu-75 for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Sep 2021 15:24:48 +0200 Original-Received: from localhost ([::1]:46086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNb5j-0004qf-7j for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Sep 2021 09:24:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNanG-0006GF-Kp for emacs-devel@gnu.org; Tue, 07 Sep 2021 09:05:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48082) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNanG-0007Gs-1L; Tue, 07 Sep 2021 09:05:42 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1594 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNanF-00071E-BH; Tue, 07 Sep 2021 09:05:41 -0400 In-Reply-To: <6c33d3c8-5155-f0fe-ec47-0630d9f3525f@yandex.ru> (message from Dmitry Gutov on Mon, 6 Sep 2021 18:43:55 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274236 Archived-At: > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > Date: Mon, 6 Sep 2021 18:43:55 +0300 > > On 06.09.2021 18:33, Eli Zaretskii wrote: > > >>> and xref-find-references? > >> > >> Also xref-find-apropos, project-find-regexp, dired-do-find-regexp and > >> any other third-party or future callers of xref-show-xrefs-function will > >> be affected by xref-auto-jump-to-first-xref. > > > > So basically xref-auto-jump-to-first-xref affects any command that is > > expected to display many matches, would that be a correct summary? > > Could be. > > Or "commands which display many matches, with high likelihood that the > user will want to visit every match, rather than just pick one". At > least that was the thinking behind xref-show-definitions-function vs > xref-show-xrefs-function. OK, I hope I fixed this stuff now, please take a look. > >>> And what about stuff like > >>> dired-do-find-regexp-and-replace -- is that affected by any of these? > >> > >> dired-do-find-regexp-and-replace is affected as well right now, but > >> that's a bug to be fixed (thanks for bringing it up). > > > > I see you fixed that already, but what about dired-do-find-regexp? > > It's in the same category as xref-find-references and others. Should > work fine already. Should we perhaps treat dired-do-find-regexp like we do with dired-do-find-regexp-and-replace, to avoid confusion due to inconsistency?