From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed menus Date: Thu, 28 Oct 2021 12:32:37 +0300 Message-ID: <83h7d1tryi.fsf@gnu.org> References: <83v91htz4d.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23644"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51446@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 28 11:33:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mg1mZ-0005oH-0z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Oct 2021 11:33:11 +0200 Original-Received: from localhost ([::1]:44014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mg1mX-00018z-Vc for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Oct 2021 05:33:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mg1mR-00018f-47 for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 05:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mg1mQ-0007Bq-RS for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 05:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mg1mQ-0006I4-JN for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 05:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Oct 2021 09:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51446-submit@debbugs.gnu.org id=B51446.163541356824156 (code B ref 51446); Thu, 28 Oct 2021 09:33:02 +0000 Original-Received: (at 51446) by debbugs.gnu.org; 28 Oct 2021 09:32:48 +0000 Original-Received: from localhost ([127.0.0.1]:51353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mg1mC-0006HU-5O for submit@debbugs.gnu.org; Thu, 28 Oct 2021 05:32:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mg1m7-0006HB-8o for 51446@debbugs.gnu.org; Thu, 28 Oct 2021 05:32:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mg1m1-00079X-Tf; Thu, 28 Oct 2021 05:32:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mr1x3LPA1cTw4MLvOPFJOfbP7GAj+rZadvl26qDemRk=; b=IiFaexbpJuDj AshpxzurmKWh7eekIdfHA11nFZM2bUSASV4myeq91Xjgm+w30regExVXlQmw+cAejjZZfCy2MBVxK D4faj5jjCBnoGv6hX4He2EKbRFpTsYsm5ZShUnvm4IEwhh/aPWaZPtJ1KRPmcA7H9X/Kp7i4oWS6+ cM/HwAog2D+FZehm8JsIep4hlYFFL31cAyWpVBzocmP5aji3umIDCWdrV4FjZRjN2KkYKV7akfE6X MUmprXfNKfUEEgLyVYLShJ6ym2j4BWwXJFE4QOnH77AbRUbbicbMDrnNvlwb6/nhCLZn/iiaW6loL 7P1Kia5++rsFd0NKAzo0Vg==; Original-Received: from [87.69.77.57] (port=3267 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mg1m0-0000Kp-Dv; Thu, 28 Oct 2021 05:32:36 -0400 In-Reply-To: (message from Stefan Kangas on Thu, 28 Oct 2021 00:27:18 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218497 Archived-At: > From: Stefan Kangas > Date: Thu, 28 Oct 2021 00:27:18 -0700 > Cc: 51446@debbugs.gnu.org > > Eli Zaretskii writes: > > > I don't understand: I seem to see the same order of the menu items in > > Emacs 27 and on the current release branch, so what am I missing? > > The regression was introduced in Emacs 26.1, in these commits: > > $ git tag --contain=bed0373855ea | head -3 > emacs-26.0.90 > emacs-26.0.91 > emacs-26.1 > $ git tag --contain=b905454680c7 | head -3 > emacs-26.0.90 > emacs-26.0.91 > emacs-26.1 > > It's the easy-to-make mistake of converting to easy-menu-define without > realizing that the order is not reversed there. Thanks. I cannot invoke image-dired-minor-mode in Emacs 25, so I cannot see the problem. I don't really understand why the order of the items in the menu matters in this case. but it doesn't matter; please go ahead and install the change.