all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 51446@debbugs.gnu.org
Subject: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed menus
Date: Thu, 28 Oct 2021 12:32:37 +0300	[thread overview]
Message-ID: <83h7d1tryi.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmk8P06WwHin0QL8zsvuSbvwJ=pgR2QuFJhZRkQapc2YaA@mail.gmail.com> (message from Stefan Kangas on Thu, 28 Oct 2021 00:27:18 -0700)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 28 Oct 2021 00:27:18 -0700
> Cc: 51446@debbugs.gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I don't understand: I seem to see the same order of the menu items in
> > Emacs 27 and on the current release branch, so what am I missing?
> 
> The regression was introduced in Emacs 26.1, in these commits:
> 
>     $ git tag --contain=bed0373855ea | head -3
>     emacs-26.0.90
>     emacs-26.0.91
>     emacs-26.1
>     $ git tag --contain=b905454680c7 | head -3
>     emacs-26.0.90
>     emacs-26.0.91
>     emacs-26.1
> 
> It's the easy-to-make mistake of converting to easy-menu-define without
> realizing that the order is not reversed there.

Thanks.  I cannot invoke image-dired-minor-mode in Emacs 25, so I
cannot see the problem.  I don't really understand why the order of
the items in the menu matters in this case.  but it doesn't matter;
please go ahead and install the change.





  reply	other threads:[~2021-10-28  9:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 19:36 bug#51446: [PATCH] image-dired: Unreverse accidentally reversed menus Stefan Kangas
2021-10-28  6:57 ` Eli Zaretskii
2021-10-28  7:27   ` Stefan Kangas
2021-10-28  9:32     ` Eli Zaretskii [this message]
2021-10-28 11:04       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h7d1tryi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=51446@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.