From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: pgtk copyright headers Date: Fri, 31 Dec 2021 14:30:46 +0200 Message-ID: <83h7apgdmx.fsf@gnu.org> References: <8735m9kt01.fsf.ref@yahoo.com> <8735m9kt01.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3838"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 31 13:32:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n3H5C-0000rQ-2b for ged-emacs-devel@m.gmane-mx.org; Fri, 31 Dec 2021 13:32:30 +0100 Original-Received: from localhost ([::1]:34052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n3H5A-0007wP-IQ for ged-emacs-devel@m.gmane-mx.org; Fri, 31 Dec 2021 07:32:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3H3O-0006it-SL for emacs-devel@gnu.org; Fri, 31 Dec 2021 07:30:38 -0500 Original-Received: from [2001:470:142:3::e] (port=37548 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3H3O-0006WF-F5; Fri, 31 Dec 2021 07:30:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2J4ShSJleqLxmJXvp+PQF7oP4YXW+/KemcuOaokox/k=; b=regnFAaiACmk EDONSQr4Z70pEyipyXeHZfu67nZVCww/sXrnmL0XseS9jAxLOklDtfhOCsdLe0g0XFrLfXpQkbUBO efzzShZrMI2S77GPE2Ts3OFPboAIawY+CycxSIme41E0Y9nlfLVKWsuJNuaLDGOR9Xr4OZFjfxF1x X9F3mNmxjflYQpaG1CLjZ08ATLabhItxh2K8BBQSzx2sFr46fDVZzZspkaZIKMxWc0Q9qWmdxOJFD pKXk//gNLeEICVxXpRPUVEGsGUpU1G5C41clnw24kgzH4Q0/LZCJGaBXyT9R906qbyqdx8tISHvfv /an1Vwn3Ytpu25fSJ3LzEA==; Original-Received: from [87.69.77.57] (port=3546 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3H3O-0002kj-2w; Fri, 31 Dec 2021 07:30:38 -0500 In-Reply-To: <8735m9kt01.fsf@yahoo.com> (message from Po Lu on Fri, 31 Dec 2021 17:45:18 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283737 Archived-At: > From: Po Lu > Date: Fri, 31 Dec 2021 17:45:18 +0800 > > The files in the PGTK port have nonsensical dates in their copyright > headers. That's probably because those files started as copies of other files in the Emacs tree. > - pgtkterm.c, pgtkfns.c, and pgtkim.c say they are copyright 1989 to > 2020, while (judging by the VCS history) they should say 2017-2021. > > - pgtkgui.h and pgtkterm.h say they are copyright 2008-2020; they > should also say 2017-2021. > > - pgtkmenu.c says it is copyright 2019-2020, while it should say > 2019-2021 instead. > > - pgtkselect.c says it is copyright 1993 to 2020, while it should say > 2017-2021. The years need to be extended to cover 2021, but I would not remove earlier years, because I'm quite sure a lot of that code was copied verbatim from other Emacs source files. The VCS dates have nothing to do with this, because the VCS doesn't track simple copies of code fragments from one file to another. > Is it okay for me to make the necessary corrections now, or are there > some legal issues that have to be taken care of first? No issues; please go ahead and fix this blunder. Thanks.