From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 52999@debbugs.gnu.org
Subject: bug#52999: 29.0.50; [PATCH v3] `eshell-eval-using-options' should follow POSIX/GNU argument conventions
Date: Wed, 05 Jan 2022 16:50:01 +0200 [thread overview]
Message-ID: <83h7ai9qzq.fsf@gnu.org> (raw)
In-Reply-To: <efcd0e6c-120b-8656-f098-6db1d34f8264@gmail.com> (message from Jim Porter on Tue, 4 Jan 2022 13:09:29 -0800)
> Cc: 52999@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
> Date: Tue, 4 Jan 2022 13:09:29 -0800
>
> I just wasn't sure if `eshell-eval-using-options' should be in the
> manual or not. Thinking it over a bit more, it would have helped me if
> it had been in the manual (I encountered this bug while trying to write
> my own Eshell built-in command), so I added some info about it to the
> manual, mostly adapted from the docstring for
> `eshell-eval-using-options'. Hopefully I followed the right conventions
> here; I'm only vaguely familiar with the Texinfo format.
Yes, the documentation part is fine, modulo some minor comments below.
> > Can these tests be made less platform-specific? For example, not all
> > the supported platforms have /dev/null, and we have a portable
> > abstraction for it.
>
> They should actually work cross-platform, since the tests don't invoke
> the commands at all; they just make sure that
> `eshell-eval-using-options' can parse the switches correctly. To make
> this a bit clearer though, I replaced "/dev/null" with "/some/path".
> Hopefully when people see that, they'll understand that this is a "fake"
> path not corresponding to anything on the actual filesystem.
Apologies for misreading this part of the code.
> +@item symbol
> +This element is the name of the Lisp symbol that will be bound to
> +@var{value}.
Is it a symbol or its name (a string)? You say "name", but the
example:
> If @var{symbol} is @code{nil}, specifying this switch
uses a symbol, not its name.
> +@item :preserve-args
> +If present, do not pass @var{macro-args} through @code{flatten-tree}
> +and @code{eshell-stringify-list}.
I think this should explain the effect of that, or the difference
between using and not using this keyword.
> +---
> +** 'eshell-eval-using-options' now follows POSIX/GNU argument syntax conventions.
> +This now accepts command-line options with values passed as a single
^^^^
"Eshell" instead of "This" will make it more clear what you mean.
Thanks.
next prev parent reply other threads:[~2022-01-05 14:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 1:36 bug#52999: 29.0.50; [PATCH] `eshell-eval-using-options' should follow POSIX/GNU argument conventions Jim Porter
2022-01-04 5:33 ` bug#52999: 29.0.50; [PATCH v2] " Jim Porter
2022-01-04 13:01 ` Eli Zaretskii
2022-01-04 21:09 ` bug#52999: 29.0.50; [PATCH v3] " Jim Porter
2022-01-05 14:50 ` Eli Zaretskii [this message]
2022-01-06 0:48 ` Jim Porter
2022-01-06 12:31 ` Eli Zaretskii
2022-01-08 19:58 ` Jim Porter
2022-01-08 20:10 ` Eli Zaretskii
2022-01-12 15:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h7ai9qzq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=52999@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.