From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53164: (After an ELC+ELN build, don't load the source file into a buffer.) fixed. Date: Tue, 11 Jan 2022 20:45:56 +0200 Message-ID: <83h7aa6rh7.fsf@gnu.org> References: <83v8yr8o0t.fsf@gnu.org> <83ilur8j0f.fsf@gnu.org> <83bl0i8nkt.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14998"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53164@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 11 20:16:04 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7Mcj-0003d8-FI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jan 2022 20:16:01 +0100 Original-Received: from localhost ([::1]:44138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7Mci-00005A-Fv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jan 2022 14:16:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7MAg-0005xa-K5 for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2022 13:47:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34399) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7MAg-0006cz-3N for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2022 13:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7MAf-0004Ox-Kc for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2022 13:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jan 2022 18:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53164 X-GNU-PR-Package: emacs Original-Received: via spool by 53164-submit@debbugs.gnu.org id=B53164.164192677316792 (code B ref 53164); Tue, 11 Jan 2022 18:47:01 +0000 Original-Received: (at 53164) by debbugs.gnu.org; 11 Jan 2022 18:46:13 +0000 Original-Received: from localhost ([127.0.0.1]:55535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7M9s-0004Ml-P3 for submit@debbugs.gnu.org; Tue, 11 Jan 2022 13:46:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7M9r-0004ML-7F for 53164@debbugs.gnu.org; Tue, 11 Jan 2022 13:46:11 -0500 Original-Received: from [2001:470:142:3::e] (port=55724 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7M9l-0006Z7-2T; Tue, 11 Jan 2022 13:46:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VcX3grvvHDbUH6HNztA6n84LDwGyEtPdqqXjOWhUYPU=; b=ehlQ4tIRTf4v c6PirKXzqk+IMwrITnGS987BH0H7Pv/wJZOt0we9TKaXco/37JLfgPe8fCX8BasBxzmK5LpbFRZNl M9aJuZ4Z4jw27pDVckEhrI4h/a4PBEmbf2hCejP35dxXlYgNSA501Vzvd5zm79SDgssCsWUeikycc LHqBUVp8/b3Mp1vtRuPGc89ioeZoZihJlGi+23Kmt5liVufl/Yah2uBwu+4iFk8iqjMkeymc39a3X V/Y9xjcGq1lfWhTtT1GuT6y9JnXQhqL8uYomSnBlt+QRHjj5tQMxjqQKhnZ48bNSkPxKsvWh+AMQx 4NBexasH2iLNtfAzp6dY3w==; Original-Received: from [87.69.77.57] (port=2905 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7M9k-0000mm-3o; Tue, 11 Jan 2022 13:46:04 -0500 In-Reply-To: (message from Alan Mackenzie on Tue, 11 Jan 2022 18:03:14 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223959 Archived-At: > Date: Tue, 11 Jan 2022 18:03:14 +0000 > Cc: 53164@debbugs.gnu.org > From: Alan Mackenzie > > > The fix is well understood, but its possible effects aren't. > > OK, we will just have to disagree on this point. If I wasn't sure about > the lack of possible negative effects, I wouldn't have committed the fix > to the emacs-28 branch. We are mis-communicating. I didn't mean something as silly as saying that the result of removing a command-line argument is not well understood. What I meant to say is that since it's impossible to look at all the possible situations where this code is being used, we cannot know what would happen due to this removal. You basically only tested the fix in one situation, where you discovered the problem, and just assume that it cannot possibly have any adverse effects on the infinity of other cases. But that's just an assumption. The reason we have long pretests is precisely because code we think we understand has unintended consequences that take a lot of time to reveal. This change is no different. > > We have been using the current code for more than a year with no > > problems whatsoever. > > None on the emacs-28 branch, perhaps. I had severe problems with the > same code on a branch branched from master. Incidentally, I timed a > bootstrap on the release branch with and without the fix, both starting > from a warm file cache. With the fix, the build ran ~7% faster. Thanks, but at this point in the pretest I no longer worry about speeding up the build. > > If you are fixing a bug that exists in the current release, you should > > generally commit it to the release branch; it will be merged to the > > master branch later by the gitmerge function. However, when the > > release branch is for Emacs version NN.2 and later, or when it is for > > Emacs version NN.1 that is in the very last stages of its pretest, > > that branch is considered to be in a feature freeze: only bug fixes > > that are "safe" or are fixing major problems should go to the release > > branch, the rest should be committed to the master branch. This is so > > to avoid destabilizing the next Emacs release. If you are unsure > > whether your bug fix is "safe" enough for the release branch, ask on > > the emacs-devel mailing list. > > OK, thanks. I'm not sure I understand any more what "safe" means in > this context. That's right, at this point no change is "safe" a-priori. > > Please install this on master (or leave it on your branch), and we > > will revisit this when time comes for Emacs 28.2. > > I'll install it on master this evening. Thanks! Thanks.