From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: damien@cassou.me, 54156@debbugs.gnu.org
Subject: bug#54156: 28.0.91; set-face-attribute with a nil FRAME doesn't change the default
Date: Sat, 26 Feb 2022 17:24:01 +0200 [thread overview]
Message-ID: <83h78lps6m.fsf@gnu.org> (raw)
In-Reply-To: <87bkytvfcz.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 26 Feb 2022 16:04:28 +0100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: damien@cassou.me, 54156@debbugs.gnu.org
> Date: Sat, 26 Feb 2022 16:04:28 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > So we need a special trick to override defface with 'unspecified', and
> > that trick is this call:
> >
> > (set-face-attribute 'region t :background 'unspecified)
> >
> > This is handled specially in internal-set-lisp-face-attribute to do
> > what Damien wants.
>
> So perhaps set-face-attribute should do that automatically when handed a
> nil value?
The fact that we handle nil as 'unspecified' in the case of the color
is for compatibility with Emacs 20. In Emacs 21 and later, a color
cannot be nil. This is well-documented: a color must be a string or
'unspecified'. I don't think we want to resurrect that old convention
of nil; it's just that Damien and others will have to get used to not
using nil for a color.
next prev parent reply other threads:[~2022-02-26 15:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 10:21 bug#54156: 28.0.91; set-face-attribute with a nil FRAME doesn't change the default Damien Cassou
2022-02-25 12:15 ` Lars Ingebrigtsen
2022-02-25 12:26 ` Eli Zaretskii
2022-02-25 12:30 ` Lars Ingebrigtsen
2022-02-25 13:03 ` Eli Zaretskii
2022-02-25 13:12 ` Lars Ingebrigtsen
2022-02-25 13:24 ` Eli Zaretskii
2022-02-25 15:42 ` bug#54156: [External] : " Drew Adams
2022-02-26 15:04 ` Lars Ingebrigtsen
2022-02-26 15:24 ` Eli Zaretskii [this message]
2022-02-26 16:17 ` bug#54156: [External] : " Drew Adams
2022-02-26 16:35 ` Eli Zaretskii
2022-02-26 17:23 ` Drew Adams
2022-02-26 17:50 ` Eli Zaretskii
2022-02-26 22:47 ` Drew Adams
2022-02-27 7:04 ` Eli Zaretskii
2022-02-27 15:49 ` Drew Adams
2022-02-27 13:02 ` Lars Ingebrigtsen
2022-02-27 16:13 ` bug#54156: [External] : " Drew Adams
2022-02-25 12:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h78lps6m.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=54156@debbugs.gnu.org \
--cc=damien@cassou.me \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.