From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use Date: Wed, 06 Jul 2022 16:12:49 +0300 Message-ID: <83h73u75bi.fsf@gnu.org> References: <87y1x7pd53.fsf@gmail.com> <83v8sb73ga.fsf@gnu.org> <87tu7vpc8y.fsf@gmail.com> <83tu7v6kjv.fsf@gnu.org> <83r12y7b0y.fsf@gnu.org> <83let676fe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20560"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56407@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 15:14:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o94r5-0005Dd-Pk for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 15:14:11 +0200 Original-Received: from localhost ([::1]:36920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o94r4-0002UQ-IF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 09:14:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o94qw-0002U1-7i for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58942) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o94qv-0003dd-VS for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:14:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o94qv-0003l4-O4 for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 13:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56407 X-GNU-PR-Package: emacs Original-Received: via spool by 56407-submit@debbugs.gnu.org id=B56407.165711318414356 (code B ref 56407); Wed, 06 Jul 2022 13:14:01 +0000 Original-Received: (at 56407) by debbugs.gnu.org; 6 Jul 2022 13:13:04 +0000 Original-Received: from localhost ([127.0.0.1]:52838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o94q0-0003jT-G4 for submit@debbugs.gnu.org; Wed, 06 Jul 2022 09:13:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o94px-0003iy-JQ for 56407@debbugs.gnu.org; Wed, 06 Jul 2022 09:13:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o94ps-0003SG-7i; Wed, 06 Jul 2022 09:12:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=nOKMElOAbh+ykDrPfZaTUvpHv2Z1650BpaFPMbtSso8=; b=ZwnMeodkDMDzaZE2Zw3g /2jF7wrUdf5ETrwW/SH4IiwtN2SL9kILbeQxrCajBIMi5KIgBGxhv/T6zZPR35up+ztxTXd69v9bJ 0mFkh51UvS/NtK7UNrxA0jK/xTz7PhRo+tqmM9sEYQof783moeq7+iVNiX/DlUfBs9GogYAyl01V2 OvHsLJG8J1Y8xhrwy4VsHIBp6SLUReUg3JAPf8koRpYwsia8kBNaoIO2QF3HbpBNZ70RjjuXC5M8D F2OGmH9yGn7iCN6OK/23rsAuqiMSMvprw+XpjbcHH5wHabiDzLNNLsvSrQE8I4RLNsXMbndTwkxMf SkiV09QPTHoc+A==; Original-Received: from [87.69.77.57] (port=2524 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o94pr-0005RK-EA; Wed, 06 Jul 2022 09:12:55 -0400 In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Wed, 6 Jul 2022 13:59:51 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236236 Archived-At: > From: João Távora > Date: Wed, 6 Jul 2022 13:59:51 +0100 > Cc: 56407@debbugs.gnu.org > > That's okay: it's desktop.el's job to know about some implementation > details. Just look at how much it knows about what the various modes > and variables do in Emacs. > > Wait, you're saying it's "okay" to have to do a commit to Emacs's repo > everytime someone makes a third-party package that has a minor mode > that needs special handling? Or everytime someone changes the name > or shape of a minor mode? eglot is not a third-party package. We intended to add it to core, I think? But if what I suggest isn't to your liking, you can always tell users to customize desktop-minor-mode-table by themselves. Or do what you didn't want to do: cause desktop.el to be autoloaded by eglot. > But we do have that mechanism. It's called symbol properties and it's a nice > feature of lisp. So let's use it, please. If you insist. But then don't come back crying when this is broken by some change in desktop.el that the "loosely coupled packages" didn't pick up.