From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56820: outline-minor-mode replacing the first character with an arrow Date: Thu, 08 Sep 2022 11:32:31 +0300 Message-ID: <83h71ifeqo.fsf@gnu.org> References: <87ilngmaei.fsf@gnus.org> <86wnaojst4.fsf@mail.linkov.net> <86mtbfdqdj.fsf@mail.linkov.net> <83ilm3ko51.fsf@gnu.org> <86edwotx6n.fsf@mail.linkov.net> <83tu5kii23.fsf@gnu.org> <86mtbcqx5u.fsf@mail.linkov.net> <83r10oih91.fsf@gnu.org> <86mtbbuj55.fsf@mail.linkov.net> <83a67bggst.fsf@gnu.org> <86edwm7351.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35668"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, yilkalargawworkneh@gmail.com, 56820@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 08 10:33:48 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWCyq-000977-Aq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 10:33:48 +0200 Original-Received: from localhost ([::1]:35876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWCyo-0008I7-Nf for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 04:33:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWCy6-0008HW-Bt for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 04:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWCy6-0001jE-0s for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 04:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWCy5-0006Vv-Kq for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 04:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Sep 2022 08:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56820 X-GNU-PR-Package: emacs Original-Received: via spool by 56820-submit@debbugs.gnu.org id=B56820.166262597525024 (code B ref 56820); Thu, 08 Sep 2022 08:33:01 +0000 Original-Received: (at 56820) by debbugs.gnu.org; 8 Sep 2022 08:32:55 +0000 Original-Received: from localhost ([127.0.0.1]:57187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWCxy-0006VW-QW for submit@debbugs.gnu.org; Thu, 08 Sep 2022 04:32:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWCxx-0006VL-D1 for 56820@debbugs.gnu.org; Thu, 08 Sep 2022 04:32:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWCxq-0001gh-5p; Thu, 08 Sep 2022 04:32:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CIyIFnlcSXCgJZrIPM40R19LEYhZMvdXN8rE8CmUfec=; b=MbcSwKf7KwG+ Ozz8hvP/BBZsOvnbgs9iUeacQ5lXeTs/ptGWZAMeRf5q2k0qRL9kqm/41JFFXmyzYmgZMrWDEwQ7T AkYV8h1L/I/5Nb2oIskoja6uyhuViuLPIDmhrz49DZEnWOn2rM1CJmbt9N26i5I4XOku8aFwN3lM+ pzIwEN7iFjlg35SgjacxQCR0cn2zAb62PmCHIF/thZaFcJTKyef8prrhgnqMiErAwf4Tk5Pl89g7X bRyz7Qq8NiMGnaEajNbxOn/QvBw9yTT2ZTtZOMXLNPcgDXZx5FjqH/DR75EHYPyHUfXfiL2f8Wgco 6RpnuCSYZ6vUB3SxjRRJRw==; Original-Received: from [87.69.77.57] (port=1302 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWCxp-0007ac-Kt; Thu, 08 Sep 2022 04:32:45 -0400 In-Reply-To: <86edwm7351.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 08 Sep 2022 10:10:18 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241842 Archived-At: > From: Juri Linkov > Cc: yilkalargawworkneh@gmail.com, larsi@gnus.org, 56820@debbugs.gnu.org > Date: Thu, 08 Sep 2022 10:10:18 +0300 > > >> Excuse my ignorance, is display-line-numbers-mode implemented by > >> using margins? > > > > No. We simply usurp a few columns from the text area, on the layout > > level of the display engine. > > I counted ~100 occurrences of display_line_numbers in xdisp.c. > So I guess display_outlines could be added based on code > for display_line_numbers using the same strategy as > tab_line was added based on header_line. > > If this is a good idea, I could look into doing this > after finishing all already opened issues, probably > around December. I don't think I understand what you mean by "same strategy" here, so I cannot answer the question yet. Vdisplay_line_numbers is used in xdisp.c for several purposes: . adjust layout calculations for the space taken by line numbers . disable some redisplay optimizations that cannot be used when line numbers (especially relative numbers) are displayed . produce and display the line numbers for relevant lines Which one(s) are "strategy" for the purpose of this discussion? I also don't think I understand which parts of the image you posted you want to emulate. In addition to outline-style widgets for folding and un-folding buffer text, the image shows vertical lines that delineate code blocks. Those are shown in the same column as the braces, and thus call for a different kind of implementation than the line numbers. I guess you didn't mean those?