From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: feature/eglot-texi-manual 4725c123f3 2/5: ; eglot.texi: Fix typos and minor inconsistenciesfeature/eglot-texi-manual 4725c123f3 2/5: ; eglot.texi: Fix typos and minor inconsistencies Date: Thu, 20 Oct 2022 13:38:28 +0300 Message-ID: <83h6zyye3f.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39406"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 20 13:16:33 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1olTXM-000A2V-7w for ged-emacs-devel@m.gmane-mx.org; Thu, 20 Oct 2022 13:16:32 +0200 Original-Received: from localhost ([::1]:37644 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olTXI-0007rS-Mc for ged-emacs-devel@m.gmane-mx.org; Thu, 20 Oct 2022 07:16:29 -0400 Original-Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olTM9-0006CS-9g for ged-emacs-devel@m.gmane-mx.org; Thu, 20 Oct 2022 07:04:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olSwc-00076T-3S for emacs-devel@gnu.org; Thu, 20 Oct 2022 06:38:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42452) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olSwb-0002iA-PY; Thu, 20 Oct 2022 06:38:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=8UKntwNHCYulSyyYurZUdcyK9Sypn+eFsTFx9FuN5Io=; b=RAhf4hE84yXeWa xEsHKoAjnDUF38PmNV2zhOGZOUCBXbIamaM7Xyokxr/J4v8FB7ma4HNRe7x3JeNbjudHdSRiPANM8 mXFcnrFnZu4J22DnuOoLLO8BExrh6CNlfNxHe0iLN3PGkLAGhTjcZeTFxGV1mrNlJcxDrPMQhngMA GURAElrUyjk2Ey9EqnBzcsEmia+ynAAIIVGSQ7zj+HY+5Wy6A4RJzOhozXDRZjkS0SryQ7XpVP7Hm eFg2t+7byHguCJIbCwlAAoZgvSJAkrgiAG96+uZCCYvBpSYArwp+VoJCZcLrqd/OJOj6awGsREjXl isAZZ290gjRPopWHHTYQ==; Original-Received: from [87.69.77.57] (port=1039 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olSwa-00011t-I4; Thu, 20 Oct 2022 06:38:33 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298142 Archived-At: I don't understand many of these changes. They seem to be personal stylistic preferences, in which case please revert them: there's nothing wrong with alternative stylistic preferences. > -on. @xref{Eglot and Buffers}, for more details of what does Eglot > -management of a buffer entail. > +on. @xref{Eglot and Buffers}, for more details of what Eglot > +management of a buffer entails. Why this change? > -packages. Here are the main features Eglot enables and provides: > +packages. These are the main features that Eglot enables and provides: And this? > -languages which are only supported by the @code{etags} backend. > +languages that are only supported by the @code{etags} backend. And this one? What's wrong with using "which" in that case? > -3rd-party completion package, is installed, Eglot enhances it by > +third-party completion package, is installed, Eglot enhances it by And what's the problem here? > -i.e.@: a VCS repository (@pxref{Version Control,,, emacs, GNU Emacs > +e.g.@: a Git repository (@pxref{Version Control,,, emacs, GNU Emacs > Manual}). This change is for the worse: project.el supports more than just Git. > -with @kbd{C-u}, it always prompts for the server program, and if > -invoked with @kbd{C-u C-u}, also prompt for the major mode. > +with a prefix argument @kbd{C-u}, it always prompts for the server > +program, and if invoked with @kbd{C-u C-u}, also prompt for the major > +mode. What was wrong with the original text here? > @item M-x eglot-shutdown > -Shut down a language server. This commands prompts for a language > +Shuts down a language server. This commands prompts for a language This is a change for the worst: the first sentence is now incomplete. > eglot.texi: Make example more realistic > > * doc/misc/eglot.texi (Eglot and Buffers): Prefer more realistic > *.c instead of *.foo in example. Why do you think it is "more realistic"? The whole point of Eglot is that it's almost agnostic to the source language, so why do we have to talk about C sources in particular? > eglot.texi: Move sentence on LSP Servers earlier > > * doc/misc/eglot.texi (Setting Up LSP Servers): Move explanation > on the (lack of) need for customizing servers earlier. Please revert that: I see no need to move the description to another place. The current text was well thought-of. Thanks.