all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gabriel <gabriel376@hotmail.com>, Stefan Kangas <stefankangas@gmail.com>
Cc: 59165@debbugs.gnu.org
Subject: bug#59165: 29.0.50; [PATCH] Ibuffer directory filter not buffer aware
Date: Thu, 10 Nov 2022 11:36:18 +0200	[thread overview]
Message-ID: <83h6z7rw19.fsf@gnu.org> (raw)
In-Reply-To: <SJ0PR06MB8609E4437601203C2F04925A8B019@SJ0PR06MB8609.namprd06.prod.outlook.com> (message from Gabriel on Thu, 10 Nov 2022 06:22:23 -0300)

> From: Gabriel <gabriel376@hotmail.com>
> Date: Thu, 10 Nov 2022 06:22:23 -0300
> 
> Description:
> The ibuffer directory filter is not buffer aware for buffers not
> visiting files. This bug seems to be introduced by commit 3ef18c7a213,
> which made the `default-directory` no longer run within
> `with-current-buffer`.
> 
> Steps:
> 1. emacs -Q (29.0.50 master d04433b96215d7d3387573f19cc315de86f2341a)
> 2. M-x dired /home/myuser/foo
> 3. M-x compile ls -lha
> 4. M-x ibuffer
> 5. / F /home/myuser/foo
> 
> Expected: filter is applied and two buffers are shown: `foo` and
> `*compilation*`.
> 
> Actual: only buffer `foo` is shown.
> 
> Patch:
> Below there is a proposed patch. I did a quick inspection and could not
> find similar regressions in other ibuffer filters.

Stefan, can you please look into this?





  reply	other threads:[~2022-11-10  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  9:22 bug#59165: 29.0.50; [PATCH] Ibuffer directory filter not buffer aware Gabriel
2022-11-10  9:36 ` Eli Zaretskii [this message]
2022-11-11  0:49 ` Stefan Kangas
2022-11-25  1:16   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h6z7rw19.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59165@debbugs.gnu.org \
    --cc=gabriel376@hotmail.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.