From: Eli Zaretskii <eliz@gnu.org>
To: Richard Hansen <rhansen@rhansen.org>
Cc: 60333@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#60333: [PATCH] whitespace: Update bob, eob markers in base and indirect buffers
Date: Thu, 12 Jan 2023 11:32:21 +0200 [thread overview]
Message-ID: <83h6wwksii.fsf@gnu.org> (raw)
In-Reply-To: <819d60c0-af5d-6936-d7ed-dc8a898adb3c@rhansen.org> (message from Richard Hansen on Thu, 29 Dec 2022 01:54:21 -0500)
> Cc: 60333@debbugs.gnu.org
> Date: Thu, 29 Dec 2022 01:54:21 -0500
> From: Richard Hansen <rhansen@rhansen.org>
>
> On 12/28/22 09:51, Stefan Monnier wrote:
> >> When a buffer is changed, update `whitespace-bob-marker' and
> >> `whitespace-eob-marker' not just in the current buffer, but
> >> also in the base buffer and all of its indirect buffers (if
> >> any) (Bug#46982).
> >
> > That doesn't sound right. We should only update them in those indirect buffers
> > which also use whitespace eob/bob markers. It should be their individual
> > responsibility to register hook functions to update their own markers.
>
> The changelog was worded poorly; it does what you expect it to do.
> Attached is an updated patch with hopefully better wording; please let
> me know if it still needs improvement.
Stefan, any further comments, or should this go in?
next prev parent reply other threads:[~2023-01-12 9:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 6:21 bug#60333: [PATCH] whitespace: Update bob, eob markers in base and indirect buffers Richard Hansen
2022-12-27 6:34 ` Ihor Radchenko
2022-12-27 12:24 ` Eli Zaretskii
2022-12-27 14:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-28 13:48 ` Ihor Radchenko
2022-12-28 14:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-29 8:11 ` Richard Hansen
2023-01-12 9:33 ` Eli Zaretskii
2023-01-12 16:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-29 11:20 ` Ihor Radchenko
2022-12-29 14:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-29 20:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-28 14:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-29 6:54 ` Richard Hansen
2023-01-12 9:32 ` Eli Zaretskii [this message]
2023-01-12 16:15 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6wwksii.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60333@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rhansen@rhansen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.