From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 b18754bb179: Minor improvements in c-ts-mode and docs Date: Wed, 15 Feb 2023 21:37:51 +0200 Message-ID: <83h6vmafe8.fsf@gnu.org> References: <167648414913.7595.16030168421819097011@vcs2.savannah.gnu.org> <20230215180229.75FF5C00613@vcs2.savannah.gnu.org> <6bd367b5-f4fc-0727-a1fc-08dfadc15c1a@yandex.ru> <1b6e0f64-35db-36f3-8d80-c3340ec50bbe@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33510"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 15 20:38:47 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSNc6-0008aC-Rk for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Feb 2023 20:38:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSNbY-0000Uu-SU; Wed, 15 Feb 2023 14:38:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSNbX-0000Ub-Id for emacs-devel@gnu.org; Wed, 15 Feb 2023 14:38:11 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSNbW-0008F3-FG; Wed, 15 Feb 2023 14:38:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5i805ZLYlMcvMhsSffxm40xaKKyTwkqshzZF0AS6Lgk=; b=JraNwfWjDC3C 3PlF5y2GyA9IMs5Al07G/Gap8w+GyvU6llz5kfqM+gDfY1CIuGR7Knk6l0hClI+wcfFgC9orI7sda IMdSY+LOkoCobBpzwSoLk5tRUERoJIrusfNGbjTU998FVg7gBOqXCDmC8L0y3YRCeL8zj2Jaa921a vzv5FaT4L7RdO/zgLs1INW6vmzfUPN7cMsZlCXNY3bu1fT6GaeC6D9w4TxZD2BIvpeaplbWxUzRg3 hT6jS3nbSnE1yVjcFzRMrJJVFHwCVIL1t01mk9CDlGQMe7Yaw4kqylj4Y8U9bqi6IdPTE6rsVQx9H eXJigbTlPY9cH6CNow6RNg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSNbV-0006uN-Os; Wed, 15 Feb 2023 14:38:10 -0500 In-Reply-To: <1b6e0f64-35db-36f3-8d80-c3340ec50bbe@yandex.ru> (message from Dmitry Gutov on Wed, 15 Feb 2023 20:50:30 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303333 Archived-At: > Date: Wed, 15 Feb 2023 20:50:30 +0200 > Cc: emacs-devel@gnu.org, Eli Zaretskii > From: Dmitry Gutov > > If M-; doesn't work adequately with transient-mark-mode off, it seems > like an area for improvement. E.g. like this: > > diff --git a/lisp/newcomment.el b/lisp/newcomment.el > index 022bf3059be..effa90371e5 100644 > --- a/lisp/newcomment.el > +++ b/lisp/newcomment.el > @@ -1364,7 +1364,8 @@ comment-dwim > You can configure `comment-style' to change the way regions are > commented." > (interactive "*P") > (comment-normalize-vars) > - (if (use-region-p) > + (if (or (not transient-mark-mode) > + (use-region-p)) This cannot be right: with it, it would be impossible to get M-; to start a new comment when transient-mark-mode is off. > I just don't see why C Mode needs that binding, whereas all other > language modes don't. Maybe it's the other way around: all other languages need "C-c C-c".