From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: acm@muc.de, emacs-devel@gnu.org
Subject: Re: emacs-29 b18754bb179: Minor improvements in c-ts-mode and docs
Date: Wed, 15 Feb 2023 21:37:51 +0200 [thread overview]
Message-ID: <83h6vmafe8.fsf@gnu.org> (raw)
In-Reply-To: <1b6e0f64-35db-36f3-8d80-c3340ec50bbe@yandex.ru> (message from Dmitry Gutov on Wed, 15 Feb 2023 20:50:30 +0200)
> Date: Wed, 15 Feb 2023 20:50:30 +0200
> Cc: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
> From: Dmitry Gutov <dgutov@yandex.ru>
>
> If M-; doesn't work adequately with transient-mark-mode off, it seems
> like an area for improvement. E.g. like this:
>
> diff --git a/lisp/newcomment.el b/lisp/newcomment.el
> index 022bf3059be..effa90371e5 100644
> --- a/lisp/newcomment.el
> +++ b/lisp/newcomment.el
> @@ -1364,7 +1364,8 @@ comment-dwim
> You can configure `comment-style' to change the way regions are
> commented."
> (interactive "*P")
> (comment-normalize-vars)
> - (if (use-region-p)
> + (if (or (not transient-mark-mode)
> + (use-region-p))
This cannot be right: with it, it would be impossible to get M-; to
start a new comment when transient-mark-mode is off.
> I just don't see why C Mode needs that binding, whereas all other
> language modes don't.
Maybe it's the other way around: all other languages need "C-c C-c".
next prev parent reply other threads:[~2023-02-15 19:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167648414913.7595.16030168421819097011@vcs2.savannah.gnu.org>
[not found] ` <20230215180229.75FF5C00613@vcs2.savannah.gnu.org>
2023-02-15 18:14 ` emacs-29 b18754bb179: Minor improvements in c-ts-mode and docs Dmitry Gutov
2023-02-15 18:31 ` Alan Mackenzie
2023-02-15 18:50 ` Dmitry Gutov
2023-02-15 19:37 ` Eli Zaretskii [this message]
2023-02-15 20:25 ` Dmitry Gutov
2023-02-16 7:09 ` Eli Zaretskii
2023-02-16 11:15 ` Dmitry Gutov
2023-02-16 12:01 ` Eli Zaretskii
2023-02-15 19:44 ` Alan Mackenzie
2023-02-15 20:29 ` Dmitry Gutov
2023-02-16 7:11 ` Eli Zaretskii
2023-02-15 18:35 ` Eli Zaretskii
2023-02-15 18:53 ` Dmitry Gutov
2023-02-15 19:39 ` Eli Zaretskii
2023-02-15 20:32 ` Dmitry Gutov
2023-02-16 7:32 ` Eli Zaretskii
2023-02-16 11:17 ` Dmitry Gutov
2023-02-16 12:03 ` Eli Zaretskii
2023-02-16 12:51 ` Dmitry Gutov
2023-02-16 15:19 ` Eli Zaretskii
2023-02-16 15:38 ` Dmitry Gutov
2023-02-16 15:53 ` Theodor Thornhill
2023-02-16 15:58 ` Eli Zaretskii
2023-02-16 20:09 ` Dmitry Gutov
2023-02-16 20:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6vmafe8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.