From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java. Date: Sat, 04 Mar 2023 09:10:17 +0200 Message-ID: <83h6v1at5y.fsf@gnu.org> References: <23F92D53-993F-43D6-8A22-00F7AAE10505@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14860"; mail-complaints-to="usenet@ciao.gmane.io" Cc: v.pupillo@gmail.com, 61913@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 04 08:11:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYM35-0003fO-5k for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Mar 2023 08:11:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYM2w-0003aU-R5; Sat, 04 Mar 2023 02:11:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYM2o-0003ZS-4f for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 02:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYM2n-00033Q-Ru for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 02:11:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYM2n-0008An-Ne for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 02:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Mar 2023 07:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61913 X-GNU-PR-Package: emacs Original-Received: via spool by 61913-submit@debbugs.gnu.org id=B61913.167791383831385 (code B ref 61913); Sat, 04 Mar 2023 07:11:01 +0000 Original-Received: (at 61913) by debbugs.gnu.org; 4 Mar 2023 07:10:38 +0000 Original-Received: from localhost ([127.0.0.1]:35157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYM2Q-0008A9-Br for submit@debbugs.gnu.org; Sat, 04 Mar 2023 02:10:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYM2O-00089w-WA for 61913@debbugs.gnu.org; Sat, 04 Mar 2023 02:10:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYM2J-0002zL-Au; Sat, 04 Mar 2023 02:10:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pfNr6vP6JYU2CBZsC6GRsIdaj9GdJxn3tKapybBHlq4=; b=QVWNe3vQx9gO D2VUkBu907m9gJXmn23NPZxgitrT7BKrAvMr2dE4xFTj4gqpKz/iyHUa+xna0J7/aNc8ZT0wcIKkU ceok10cuxr9orlTUfwkO/NdBuFxseTTjmCox/Ugtu16jjW54WUo0S4aj/FFFMPMmLighBsmfIgcfd HjFXwyVcietoZ6Lg0ZWqpVG5iS3KnwjS+FK1gjaNsRsFUm+c7oCYg5GF0OUfoHnkWSE6OyPo0TFg6 +L93vWDm4KcwB6vG/JyJECHH4IzMcsB0QRe4ZjOmtECoiFzP2ZPdsaladsqmqUxaDYjDyP/LCv14A MhCNRC6Yy8q0GRD+Lu5JQQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYM2I-0005w8-1b; Sat, 04 Mar 2023 02:10:31 -0500 In-Reply-To: <23F92D53-993F-43D6-8A22-00F7AAE10505@gmail.com> (message from Yuan Fu on Fri, 3 Mar 2023 14:32:02 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257253 Archived-At: > From: Yuan Fu > Date: Fri, 3 Mar 2023 14:32:02 -0800 > Cc: Eli Zaretskii , > 61913@debbugs.gnu.org > > >> > Error during redeployment: (jit-lock-function 8295) reported > >> > (treesit-query-error "Node type error at" 42 "(string_literal) > >> > @font-lock-string-face (text_block) @font-lock-string-face" > >> > "Debugging the query with `treesit-query-validate'") > >> > > >> > > >> > The attached patch fixes the problem. > >> > >> Wouldn't removing text_block from our code cause problems if someone > >> uses tree-sitter-java from before the removal? > >> > >> Is there a way to write code which handles text_block if it exists? > >> > > Tree-sitter language grammars really need some versioning system. I > wonder how do we propose such things to them tho... That'd be hard, given that many of them don't even make releases. It should be enough for our purposes to have a possibility of querying the grammar about support for specific features. Then the version will not matter, only the supported features will. Maybe we could do that ourselves, on-the-fly, like we do with programs when we want to know whether they support some command-line switch?