From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63221: 30.0.50; [PATCH] Eshell should get user (and group) IDs in a connection-aware fashion Date: Tue, 02 May 2023 21:44:25 +0300 Message-ID: <83h6sumv3q.fsf@gnu.org> References: <473147ec-87a1-8a2a-9062-bbdef41da3ac@gmail.com> <83bkj3ndw0.fsf@gnu.org> <79c20cb6-3b54-a386-c62f-39c736089951@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26740"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63221@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 02 20:44:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptuz7-0006mv-Eu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 May 2023 20:44:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptuyq-0002aA-6C; Tue, 02 May 2023 14:44:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptuyo-0002a1-Ny for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 14:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptuyo-0006ty-2n for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 14:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptuyn-0005EQ-KY for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 14:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 May 2023 18:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63221 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63221-submit@debbugs.gnu.org id=B63221.168305303220089 (code B ref 63221); Tue, 02 May 2023 18:44:01 +0000 Original-Received: (at 63221) by debbugs.gnu.org; 2 May 2023 18:43:52 +0000 Original-Received: from localhost ([127.0.0.1]:45063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptuyd-0005Dv-Mj for submit@debbugs.gnu.org; Tue, 02 May 2023 14:43:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptuyY-0005De-LU for 63221@debbugs.gnu.org; Tue, 02 May 2023 14:43:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptuyS-0006rP-TL; Tue, 02 May 2023 14:43:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YmGbY0W/SAk/InH1y4TNuZd7fjNCjlNxBLjfuP8m3Ho=; b=UHDw03gLCqQ2 fAQjUvMpBQ3jYmc46cTt+c0zQH3WVgys0T1cgD4EGjA3sGh+cJUsVj20eFXXXflSWiF2WEmtYFv0v ryjj1enVPskW7fQVDDbxNBvyzGryCFr8nDuvF1L5VOXXMXKfjkqkiKlD0iqCAEzMD7rZ2yGt/Qkeb NiiWIeOfvvP6flizJmSuHSOmFpugEOcAAdMiK+s2DMq69XuDa/vVQ7xrLgRINVCExQKmwGm6SYKuA 1xawQhtlsE4qsVAkD315ULZBOq2KqWh7SzToHauKkgUtiP9mRPnlKX2rjqHhtRHXsE2vzpoEZ3Cj7 H9wAyR68uyVAWy5y/plS+g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptuyS-0006PD-51; Tue, 02 May 2023 14:43:40 -0400 In-Reply-To: <79c20cb6-3b54-a386-c62f-39c736089951@gmail.com> (message from Jim Porter on Tue, 2 May 2023 11:36:16 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260956 Archived-At: > Date: Tue, 2 May 2023 11:36:16 -0700 > Cc: 63221@debbugs.gnu.org > From: Jim Porter > > > This terse sentence needs to be explained in the rest of the doc > > string, because, unlike "If non-nil", "When" does not explain itself. > > The doc string should explain how to specify "when". It should also > > explain the different supported values. > > Thanks, fixed. > > >> + :tag "Query" > >> + :type '(choice (const :tag "Never" nil) > >> + (const :tag "Always" t) > >> + (const :tag "When root" root))) > > > > Also, the default value is not one of the possible optional values. > > I changed how this works so now the widget inherits from 'radio' instead > of 'lazy', and I think it should work better overall now. > > > Same comment to the other similar defcustoms where you changed a > > boolean option to something else: their doc strings are now > > obfuscated. > > Fixed. > > >> +(defun eshell-interactive-query-p (value) > >> + "Return non-nil if a command should query the user according to VALUE. > >> +If VALUE is `root', return non-nil when evaluated as root (see > >> +`file-user-uid'). Otherwise, simply return VALUE." > > > > You assume here that "evaluated as root" explains itself? I wouldn't > > rely on that. > > Also fixed. Thanks, LGTM.