From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 63221@debbugs.gnu.org
Subject: bug#63221: 30.0.50; [PATCH] Eshell should get user (and group) IDs in a connection-aware fashion
Date: Tue, 02 May 2023 21:44:25 +0300 [thread overview]
Message-ID: <83h6sumv3q.fsf@gnu.org> (raw)
In-Reply-To: <79c20cb6-3b54-a386-c62f-39c736089951@gmail.com> (message from Jim Porter on Tue, 2 May 2023 11:36:16 -0700)
> Date: Tue, 2 May 2023 11:36:16 -0700
> Cc: 63221@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> > This terse sentence needs to be explained in the rest of the doc
> > string, because, unlike "If non-nil", "When" does not explain itself.
> > The doc string should explain how to specify "when". It should also
> > explain the different supported values.
>
> Thanks, fixed.
>
> >> + :tag "Query"
> >> + :type '(choice (const :tag "Never" nil)
> >> + (const :tag "Always" t)
> >> + (const :tag "When root" root)))
> >
> > Also, the default value is not one of the possible optional values.
>
> I changed how this works so now the widget inherits from 'radio' instead
> of 'lazy', and I think it should work better overall now.
>
> > Same comment to the other similar defcustoms where you changed a
> > boolean option to something else: their doc strings are now
> > obfuscated.
>
> Fixed.
>
> >> +(defun eshell-interactive-query-p (value)
> >> + "Return non-nil if a command should query the user according to VALUE.
> >> +If VALUE is `root', return non-nil when evaluated as root (see
> >> +`file-user-uid'). Otherwise, simply return VALUE."
> >
> > You assume here that "evaluated as root" explains itself? I wouldn't
> > rely on that.
>
> Also fixed.
Thanks, LGTM.
next prev parent reply other threads:[~2023-05-02 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 5:42 bug#63221: 30.0.50; [PATCH] Eshell should get user (and group) IDs in a connection-aware fashion Jim Porter
2023-05-02 11:58 ` Eli Zaretskii
2023-05-02 18:36 ` Jim Porter
2023-05-02 18:44 ` Eli Zaretskii [this message]
2023-05-03 4:30 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6sumv3q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=63221@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.