From: Eli Zaretskii <eliz@gnu.org>
To: Basil Contovounesios <contovob@tcd.ie>
Cc: 63552@debbugs.gnu.org, arstoffel@gmail.com
Subject: bug#63552: 29.0.91; M-x completion-predicate does not account for python-ts-mode
Date: Wed, 17 May 2023 15:40:03 +0300 [thread overview]
Message-ID: <83h6sbxhb0.fsf@gnu.org> (raw)
In-Reply-To: <87353vrx4f.fsf@tcd.ie> (bug-gnu-emacs@gnu.org)
> Cc: Augusto Stoffel <arstoffel@gmail.com>
> Date: Wed, 17 May 2023 12:54:56 +0100
> From: Basil Contovounesios via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> At the time of https://bugs.gnu.org/57184 python-ts-mode did not yet
> exist, so the completion-predicates added to python.el as part of that
> report understandably assumed only python-mode exists.
>
> Here's what that means in practice:
>
> 0. emacs -Q
> 1. (setq read-extended-command-predicate
> #'command-completion-default-include-p)
> 2. C-x C-e
> 3. M-x python-ts-mode RET
> 4. M-x python-sort TAB
> => [No match]
>
> And yet python-sort-imports is present in the local map:
>
> 5. C-g
> 6. C-h f python-sort-imports RET
> => It is bound to C-c TAB s.
>
> By contrast, in python-mode:
>
> 7. M-x python-mode RET
> 8. M-x python-sort TAB
> => Completes to python-sort-imports
>
> The following patch fixes this by associating M-x completion with
> python-base-mode rather than python-mode:
Thanks.
We need to fix tis on the emacs-29 branch, so I wonder whether the fix
can be simpler? After all, we just need to test one more major mode,
right?
If a simpler fix is less clean, we could install a simpler change on
emacs-29 and a cleaner one on master.
next prev parent reply other threads:[~2023-05-17 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 11:54 bug#63552: 29.0.91; M-x completion-predicate does not account for python-ts-mode Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-17 12:40 ` Eli Zaretskii [this message]
2023-05-17 12:59 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-17 13:33 ` Eli Zaretskii
2023-05-17 14:16 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-18 11:55 ` Eli Zaretskii
2023-05-18 12:15 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6sbxhb0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=63552@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.