From: Eli Zaretskii <eliz@gnu.org>
To: Karl Fogel <kfogel@red-bean.com>
Cc: matsl@gnu.org, emacs-devel@gnu.org
Subject: Re: Odd behavior when moving point over invisible text
Date: Mon, 05 Jun 2023 16:05:31 +0300 [thread overview]
Message-ID: <83h6rm3vqc.fsf@gnu.org> (raw)
In-Reply-To: <87y1kybd1a.fsf@red-bean.com> (message from Karl Fogel on Mon, 05 Jun 2023 02:09:53 -0500)
> From: Karl Fogel <kfogel@red-bean.com>
> Cc: emacs-devel@gnu.org
> Date: Mon, 05 Jun 2023 02:09:53 -0500
>
> The reason I'm looking into your report was because I thought it
> might be related to a known bug in indent.c:check_display_width()
It isn't.
> I looked around in the code a bit for your bug.
> cmds.c:Fforward_char() just calls move_point(), which in turn
> looks like it boils down to calling intervals.c:set_point(), which
> gets us to set_point_both() and that appears to finally be where
> some interesting action starts. So is there a call to
> scan_for_column(), or something else that gets us to
> check_display_width(), somewhere within set_point_both() in the
> call stack? Maybe? I don't yet know.
No, those are not relevant. What happens here is the feature known as
"point-adjustment" kicks in, and attempts to move point out of
invisible text. See disable-point-adjustment for more details.
> I also don't know why `forward-char' is behaving differently in
> your reproduction recipe when called via `C-f' versus other ways.
> That's quite odd IMHO! Both `M-x forward-char' and direct
> minibuffer evaluation of `(forward-char 1)' result in point
> staying on the first dot, just as you said, which is position 15
> in the buffer. Whereas typing `C-f' moves point over the whole
> ellipsis and goes to position 28 in the buffer. What's up with
> that? There doesn't seem to be any advice added to anything by
> outline.el (disclaimer: I'm not very familiar with the advice
> mechanism in Emacs). For example, calling `(ad-has-any-advice
> 'forward-char)' within the reproduction buffer returns nil.
It's a bug. Bugs are often odd. The point-adjustment feature needs
to record the previous position of point, to know in which direction
to move it in order to exit the invisible area: if point moved to a
larger buffer position and entered invisible text, point-adjustment
wants to move it further forward; if it moved towards lower position,
point-adjustment wants to move it back. The bug was that last point
position was recorded in a global variable, and M-x enters
recursive-edit, which clobbered that variable's value with the value
from the minibuffer.
next prev parent reply other threads:[~2023-06-05 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 21:43 Odd behavior when moving point over invisible text Mats Lidell
2023-06-05 7:09 ` Karl Fogel
2023-06-05 13:05 ` Eli Zaretskii [this message]
2023-06-05 17:51 ` Karl Fogel
2023-06-05 19:38 ` Mats Lidell
2023-06-05 12:59 ` Eli Zaretskii
2023-06-05 23:30 ` Mats Lidell
2023-06-06 11:48 ` Eli Zaretskii
2023-06-06 12:07 ` Mats Lidell
2023-06-06 12:22 ` Eli Zaretskii
2023-06-06 22:45 ` Mats Lidell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6rm3vqc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
--cc=matsl@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.