From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65386: [PATCH] ; Refine some 'package-vc' docstrings Date: Sun, 20 Aug 2023 09:05:49 +0300 Message-ID: <83h6ouxn7m.fsf@gnu.org> References: <83msymyfun.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18320"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 65386@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 20 08:06:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXbZx-0004Zv-Jw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Aug 2023 08:06:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXbZm-0005ah-7S; Sun, 20 Aug 2023 02:06:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXbZZ-0005XC-5E for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 02:06:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXbZY-0000uF-Sr for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 02:06:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXbZa-00006e-78 for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 02:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 06:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65386 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65386-submit@debbugs.gnu.org id=B65386.1692511544372 (code B ref 65386); Sun, 20 Aug 2023 06:06:02 +0000 Original-Received: (at 65386) by debbugs.gnu.org; 20 Aug 2023 06:05:44 +0000 Original-Received: from localhost ([127.0.0.1]:52732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXbZI-00005v-5A for submit@debbugs.gnu.org; Sun, 20 Aug 2023 02:05:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXbZG-00005a-Lu for 65386@debbugs.gnu.org; Sun, 20 Aug 2023 02:05:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXbZ8-0000gL-QV; Sun, 20 Aug 2023 02:05:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3BxvMR+p/BGPUenabyZhpd7z/nkF1C8Zv8LoEczwn80=; b=oBA/GKYJY+QH CUdn6BJySQIjONERE/hxd0hOr46sh+b8JnDH8f8HCfAPE04Jl2aWh1mLLQ+Dbu4iRmmJYSBt5RpMz Gk89UNqbM7tuRnKl/pyOhjabF05Frq8F751+gXq1CdwCzf7S+h7MZLIJTr+NZ9uGAetEZJuTwgje9 A4CJWfWRgpASCVkixFGRterlwWLFG8GttAjwZ6cGIRJFewvBzzYEwV2d8DdVEhIvlTepKn3D7ydwa QdskXbiGtWwFvArw/jykWhCMrIsanA8cht0H4b8FXoklRr/iTc9RAb72FcF+MbsV3AZ3qKLpaiGA2 dl+KnOBep0VeEsFzJEPeEQ==; In-Reply-To: (message from Eshel Yaron on Sat, 19 Aug 2023 22:42:57 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267942 Archived-At: > From: Eshel Yaron > Cc: 65386@debbugs.gnu.org, philipk@posteo.net > Date: Sat, 19 Aug 2023 22:42:57 +0200 > > >> -(defcustom package-vc-selected-packages '() > >> - "List of packages that must be installed. > >> -Each member of the list is of the form (NAME . SPEC), where NAME > >> -is a symbol designating the package and SPEC is one of: > >> + > >> +(defcustom package-vc-selected-packages nil > >> + "List of packages to install from source. > > > > What is the significance of "from source" here? > > > > It's just for indicating that we're talking about VC packages > specifically. Does that make sense? Then how about List of packages to install from their VCS repositories. > >> + "Send patch for REVISIONS to maintainer of the package PKG-DESC using SUBJECT. > > > > This should mention email, otherwise SUBJECT is confusing. Maybe use > > "Email" instead of "Send". > > Alright, I made a couple more changes to this one. Now you have lost the reference to SUBJECT. Was that necessary? We generally try to mention all the mandatory arguments in the first line of the doc string. The sentence below seems to be squeezable into 79 columns: Email patches for REVISIONS to maintainer of package PKG-DESC using SUBJECT. (Dropping articles is a frequent trick to make the first line fit.)