From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65491: [PATCH] Improve performance allocating vectors Date: Mon, 18 Sep 2023 20:13:45 +0300 Message-ID: <83h6nre75i.fsf@gnu.org> References: <6B2EDD07-AAEB-40E8-B369-F634296BD3D9@gmail.com> <83v8cagkqv.fsf@gnu.org> <83ttrugkj2.fsf@gnu.org> <83r0mygi4y.fsf@gnu.org> <8af6fa1c-4873-bd6e-e896-ab5bb8d012a2@cs.ucla.edu> <83led5gyxa.fsf@gnu.org> <83o7i0g4i9.fsf@gnu.org> <83jzsog35g.fsf@gnu.org> <95C2D44B-BA1B-47F5-8279-B3A3B8F7EB39@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30343"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65491@debbugs.gnu.org, eggert@cs.ucla.edu, monnier@iro.umontreal.ca To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 18 19:15:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiHq0-0007hS-4K for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Sep 2023 19:15:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiHpn-0000F2-OH; Mon, 18 Sep 2023 13:14:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiHpm-0000Ed-42 for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 13:14:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qiHpl-0001p0-QR for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 13:14:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qiHpt-0000rd-Pw for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 13:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2023 17:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65491-submit@debbugs.gnu.org id=B65491.16950572513235 (code B ref 65491); Mon, 18 Sep 2023 17:15:01 +0000 Original-Received: (at 65491) by debbugs.gnu.org; 18 Sep 2023 17:14:11 +0000 Original-Received: from localhost ([127.0.0.1]:54290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiHp5-0000q7-0D for submit@debbugs.gnu.org; Mon, 18 Sep 2023 13:14:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiHp0-0000pk-QP for 65491@debbugs.gnu.org; Mon, 18 Sep 2023 13:14:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiHom-0001dY-5w; Mon, 18 Sep 2023 13:13:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=sXqea6OxXFjCj2ru8CskxgMn4Vc2EFWtL70D1o7eOYk=; b=cYKuME245te4wcfJxqyC FKGo1eq9PJxOHfJ/8Yf+YANS7EhlfZJ2x+HeqnBOIG9HUG9UBkRZhJxzZj6hUy/KQ2Gtjxrx4TBrv axlz3HQCxdT9fxRUbj3hUqMHR1RsNvDYu4ODJMJOTjZjhINugd6EXkMuy8boDSCo+FUesW74IyguP oHdMbsxpzc+IvPYoUbBAUpJdqAagrGGxL73I33izaOY0ga8cak0PlGP5xI4Lmm7GGUDUbugvROiOU fUzPlz9a9AiD2stiz9s3OUwCSmw7MO75BeqZmvVoltGLzC6XeO4bSJqjhYwJtz1/4FHCqelZQy3Nr FyPArynEyiunEg==; In-Reply-To: <95C2D44B-BA1B-47F5-8279-B3A3B8F7EB39@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 18 Sep 2023 18:10:47 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270827 Archived-At: > From: Mattias Engdegård > Date: Mon, 18 Sep 2023 18:10:47 +0200 > Cc: Paul Eggert , > 65491@debbugs.gnu.org, > monnier@iro.umontreal.ca > > 17 sep. 2023 kl. 18.44 skrev Eli Zaretskii : > > > Feel free to add any comments you find useful, that is always welcome. > > But comments about complicated code have one downside: they need to be > > updated when the code changes, and people forget to do that... > > Eli and Paul, thank you very much. I'm reapplying the patches (that we now know shouldn't cause warnings), with added comments with respect to the vanishing subtrahend in -with-wide-int builds. Fine with me, but I still hope Paul will do good on his proposal to add comments... > The conversion at the other end, TAG_PTR, suffers from the same potential problem but in reverse, which is perhaps less obvious to the casual C programmer but nevertheless a danger of the same kind, so we'd better do something about it as well. I'll be back with a proposed patch. Thanks.