From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65854: Multi-file replacement diff Date: Sat, 23 Sep 2023 21:56:01 +0300 Message-ID: <83h6nk4t32.fsf@gnu.org> References: <86sf7mgd54.fsf@mail.linkov.net> <86bke943tp.fsf@mail.linkov.net> <83jzswrios.fsf@gnu.org> <86o7i7oo9t.fsf@mail.linkov.net> <86sf7g548a.fsf@mail.linkov.net> <83pm2jkhsg.fsf@gnu.org> <86msxeu1q3.fsf@mail.linkov.net> <83zg1e7jq3.fsf@gnu.org> <86o7hunqyu.fsf@mail.linkov.net> <83jzsi5h1n.fsf@gnu.org> <86r0movlkt.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39680"; mail-complaints-to="usenet@ciao.gmane.io" Cc: me@eshelyaron.com, 65854@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 23 20:57:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qk7om-000A4U-C3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Sep 2023 20:57:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qk7oJ-0002br-AJ; Sat, 23 Sep 2023 14:56:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qk7oF-0002b4-Tb for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 14:56:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qk7oB-0001J0-1g for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 14:56:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qk7oM-0001iH-Bl for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 14:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Sep 2023 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65854-submit@debbugs.gnu.org id=B65854.16954953726521 (code B ref 65854); Sat, 23 Sep 2023 18:57:02 +0000 Original-Received: (at 65854) by debbugs.gnu.org; 23 Sep 2023 18:56:12 +0000 Original-Received: from localhost ([127.0.0.1]:40616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk7nY-0001h7-Aa for submit@debbugs.gnu.org; Sat, 23 Sep 2023 14:56:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk7nV-0001gn-7D for 65854@debbugs.gnu.org; Sat, 23 Sep 2023 14:56:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qk7nD-0001CV-Lh; Sat, 23 Sep 2023 14:55:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fls9P5ddjW8hCZFw/MN6PVugTULMXsbPIVt1wYAbLIs=; b=Q+hqJs0x/VTK p5BwQ/NDYh7/4zh2Ar6eYkwBFASDFCUaPCSxn34Rk2E63By86cuWdmOeuuZrSxiwiPbb9IypOGWZZ BO+bzOgXe/OP5+lJzhX0o48PWChg/ZJWdKMQSNULWMgJQgTllI71bUqEGhORNWLnCG6wPYhoJY31V jNiPzDTZsDtue8Ye1x9rb+b1fg5Sjgq3tSM+O7jv6N1UdpfzRSs4kjQZAH1shWbrF6/sD9jeMmmhK bKf3crmS0jyF/fd/S+sWOFq+T9B1uJPv8Ryr2hD4esdA/+k3s41cmnoJsf6lqr9kiUS/mSwDkwSlY QRnbEhS64RQR6lGTM/mXag==; In-Reply-To: <86r0movlkt.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 23 Sep 2023 20:36:02 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271183 Archived-At: > From: Juri Linkov > Cc: me@eshelyaron.com, 65854@debbugs.gnu.org > Date: Sat, 23 Sep 2023 20:36:02 +0300 > > >> >> + However, when the file > >> >> +is not visited in a buffer, or the buffer is not modified, still read > >> >> +contents from the file." > >> > > >> > Seems to describe an implementation detail, and I don't think it > >> > should be there. E.g., what if the file visited by the buffer no > >> > longer exists? > >> > >> If the file visited by the buffer no longer exists, then > >> the standard error is signaled. > > > > Which means in that case it is better to use the buffer text, no? > > Since replacement diffs are not supported in non-file buffers, > better to signal an error for heads up. But it _is_ a file-visiting buffer. It's just that its file was deleted meanwhile.