From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67061: [PATCH] Improve syntax highlighting for python-ts-mode Date: Sat, 11 Nov 2023 13:00:59 +0200 Message-ID: <83h6lswo44.fsf@gnu.org> References: <8734xdni6y.fsf@yandex.ru> <831qcwycbj.fsf@gnu.org> <355881699699654@mail.yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9440"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 67061@debbugs.gnu.org To: Denis Zubarev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 11 12:01:43 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1lkE-0002Ke-Ay for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Nov 2023 12:01:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1ljw-0007He-Hp; Sat, 11 Nov 2023 06:01:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1lju-0007HS-8J for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 06:01:22 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1lju-0002R8-0U for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 06:01:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1lkY-0005SY-82 for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 06:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2023 11:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67061 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67061-submit@debbugs.gnu.org id=B67061.169970051420973 (code B ref 67061); Sat, 11 Nov 2023 11:02:02 +0000 Original-Received: (at 67061) by debbugs.gnu.org; 11 Nov 2023 11:01:54 +0000 Original-Received: from localhost ([127.0.0.1]:52152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1lkQ-0005SD-0O for submit@debbugs.gnu.org; Sat, 11 Nov 2023 06:01:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1lkL-0005Rt-SA for 67061@debbugs.gnu.org; Sat, 11 Nov 2023 06:01:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1ljb-0002Nw-RA; Sat, 11 Nov 2023 06:01:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rRljS28RV/HHXviQFqTCKFp6qTbDsUQrXkISlirzKbs=; b=AVtnj0QKgJMB 21+M9Zv4IEs96D0mfeae/unHqdiCCoaomYne3nTcTTsslIyakguPxl2DTjH9atRpUIexn+dNyAldo 7E6rdchniXITUFnWfIOwWifN/d93tRpUKjk0qnoZJFtibpEHtyZHKjJKHroew8ffmMN5InslDmPzl LowfEiID98uckGhK0nNOXON09EQKhWRmZY1S47agf0oD54v0SPeMs6rARWRuEmX81iOHBLlQjS3mX 9So4lwgKnMDI56NyOX/QoRzbgUgeVr8QHlgRg6PhcHZsfkfTT0XfQUJyf7EHWL0MzVyTQlCujEwjr YZXp6mc8HougfaXKDactEg==; In-Reply-To: <355881699699654@mail.yandex.ru> (message from Denis Zubarev on Sat, 11 Nov 2023 13:52:45 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274156 Archived-At: > From: Denis Zubarev > Cc: "67061@debbugs.gnu.org" <67061@debbugs.gnu.org> > Date: Sat, 11 Nov 2023 13:52:45 +0300 > > My only comment is that we should decide in which fontification > level(s) should the additional fontifications be. > > I didn't add any new features, just tweak the old ones to be more correct. I thought at least some of these are new: > > - Fontify compound keywords "not in" and "is not" (fixes bug#67015) > > - Fix fontification of strings inside of f-strings interpolation, > > e.g. for f"beg {'nested'}" - 'nested' was not fontified as string. > > - Do not override the face of builtin functions (all, bytes etc.) with > > the function call face > > - Add missing assignment expressions > > - Fontify built-ins (dict,list,etc.) as types when they are used in type hints For example, isn't the first item an addition? And what about "missing assignment expressions"? > What problems with CI did you see? I don't think I understand your > last sentence above. > > I've grepped the codebase and found those lines: > > TREE-SITTER-FILES ?= $(shell cd .. ; \ > find lisp src \( -name "*-ts-mode-tests.el" -o -name "treesit-tests.el" \) | \ > sort | sed s/\\.el/.log/) > > in test/infra/Makefile.in > I thought that tree-sitter tests should go to either *-ts-mode-tests.el or treesit-tests.el files. No, I don't think so. If having them in python-tests.el triggers some problems, please show them, and let's take it from there. > Would you like to start your assignment copyright > paperwork rolling at this time? If yes, I will send you the form to > fill and the instructions to email it. > > Yes, please. Thanks, form sent off-list.