From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67460: [PATCH] Add ert-font-lock Date: Sat, 02 Dec 2023 14:50:17 +0200 Message-ID: <83h6l093au.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11182"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67460@debbugs.gnu.org To: Vladimir Kazanov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 02 13:51:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r9PSp-0002j8-Bp for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Dec 2023 13:51:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9PSU-00057i-GA; Sat, 02 Dec 2023 07:50:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9PSO-00057A-Vj for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 07:50:54 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9PSO-00050R-MR for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 07:50:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r9PSX-0006H8-Vl for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 07:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Dec 2023 12:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67460 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67460-submit@debbugs.gnu.org id=B67460.170152144924104 (code B ref 67460); Sat, 02 Dec 2023 12:51:01 +0000 Original-Received: (at 67460) by debbugs.gnu.org; 2 Dec 2023 12:50:49 +0000 Original-Received: from localhost ([127.0.0.1]:56857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9PSL-0006Gi-8X for submit@debbugs.gnu.org; Sat, 02 Dec 2023 07:50:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9PSJ-0006GT-M0 for 67460@debbugs.gnu.org; Sat, 02 Dec 2023 07:50:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9PS4-0004zh-OP; Sat, 02 Dec 2023 07:50:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xrKkM3o4qwBw69b8aSA96Evd3oX5Pq9RNB6eVJ9/0K0=; b=k+uLdegs7p5F 7Mh31RtVSJIUK+gm62xVfetjEVODtC63V44K4m1T9n5X73wso5Xbp22IXkBjDSWWpShpAKPfqBNpj gcB13MCEvB9JYlUTaBi3EsWG0qpuBzk0WPfVzgwP5+lS4EAg/CBUYoSdh9Xib0YJf9diHNezyUOAL KJXKnbfey/20BT5RSJLUb6VeEKZfviwDOlAakJ7hgKUIqxiAJZ1mwd1Z0ej61JMZXSdWmfveJSZ41 KGDXgJRpSDImIf8yBiXxk39UuJMFVRlJ/HHVZ1YJaUCpgLVWkGf0PZR+HvLU1BK8KGARvV98gOyBk AfhR6D10gUlrV0AUso1zMw==; In-Reply-To: (message from Vladimir Kazanov on Sun, 26 Nov 2023 18:47:30 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275372 Archived-At: > From: Vladimir Kazanov > Date: Sun, 26 Nov 2023 18:47:30 +0000 > > As suggested in emacs-devel@ [1], this patch adds ert-lont-lock.el to > Emacs. Ert-font-lock is an extension to ERT providing an easy way to > check font faces either in inline strings or resource files. > > The assertion syntax is based on Tree-sitter's syntax highlighter unit > tests [2]. This makes it easy to port existing tree-sitter grammar > tests to support both new-style ts-based major modes and the > traditional ones. Thanks. Byte-compiling this I get two warnings: ELC emacs-lisp/ert-font-lock.elc In ert-font-lock--parse-macro-args: emacs-lisp/ert-font-lock.el:82:19: Warning: Unused lexical variable `keys' In ert-font-lock--comment-start-p: emacs-lisp/ert-font-lock.el:191:10: Warning: `derived-mode-p' called with 3 arguments, but accepts only 1 Could you please fix these and resubmit the patch?