From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68547: [PATCH] ; Fix 'mode-line-format-right-align' with ElDoc Date: Sun, 21 Jan 2024 07:18:59 +0200 Message-ID: <83h6j7s1q4.fsf@gnu.org> References: <83cytwtjiw.fsf@gnu.org> <83plxvsweh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38522"; mail-complaints-to="usenet@ciao.gmane.io" Cc: me@eshelyaron.com, 68547@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 21 06:20:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rRQFg-0009qq-3b for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jan 2024 06:20:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRQFU-0001Gb-TL; Sun, 21 Jan 2024 00:20:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRQFT-0001GP-KA for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 00:19:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRQFT-0004hc-4u for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 00:19:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rRQFV-0001yK-Sp for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 00:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jan 2024 05:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68547-submit@debbugs.gnu.org id=B68547.17058143707530 (code B ref 68547); Sun, 21 Jan 2024 05:20:01 +0000 Original-Received: (at 68547) by debbugs.gnu.org; 21 Jan 2024 05:19:30 +0000 Original-Received: from localhost ([127.0.0.1]:36372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRQEz-0001xN-Rr for submit@debbugs.gnu.org; Sun, 21 Jan 2024 00:19:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRQEv-0001x7-56 for 68547@debbugs.gnu.org; Sun, 21 Jan 2024 00:19:28 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRQEm-0004eC-D1; Sun, 21 Jan 2024 00:19:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=26wjgiezBXGYKAmDjDveJ2+t0E/rfi/YdF34FPmnKIg=; b=D09peztU5vHeXo9pBi/X aKp0JTZIoj/JhSdUWNYneGxcTtXiddhgrZPsiuXBSRwrydE7knzrjjmYGH/SYvl36DRlYudj6p9lD nVjK9H9Bi/9V95R5W8J2JwTn2m8lTSgbtEiiE2VYzKre7zRqFvTorqW0+ouzuPM1jymgy2OkAXusj Saruj1uyqRZqIaFSxwiVOXhk0Bar5fFncIwaPG63S9BBIK3ekMv+S0J2TqDCkeV9nWWdx3Z+U+OY+ oNbseaZa9TlZ4a5mnlmdsSqbKB7FSyOGfFxZ3VyomVy5lAWWz9/N83nAE8YOaVHYRqCb2US/ORjor 8bt6hNE86N2Nag==; In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sat, 20 Jan 2024 21:12:22 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278647 Archived-At: > From: João Távora > Date: Sat, 20 Jan 2024 21:12:22 +0000 > Cc: me@eshelyaron.com, 68547@debbugs.gnu.org > > > Does this remove a function that existed before? If so, please don't, > > since that function's name didn't include "--", so it was not an > > internal function. > > The function eglot-minibuffer-message is a value for > eldoc-message-function and it's "external" indeed. But not by > design rather by "status quo" -- i.e. because at the time it was > introduced, the '-- 'convention was not always observed. > > The correct way to customize ElDoc's messaging outlet is to > set 'eldoc-message-function', the variable. That doesn't > require referencing the should-have-been-internal symbol. It does, if some Lisp program wants to reset the value back for some reason. > > (I also find the tendency of using internal functions as values of > > variables that are clearly meant to be customized by modes to be > > undesirable. They are not really internal functions.) > > I see nothing wrong with it. What is wrong with it is that it's a possible value of a public variable, so the value is basically public by definition. > But as you noted, because of this design mistake, I've noticed > a small number of modes do set it via 'setq'. The correct way > would be to create an obsolete alias. But if you don't want > to I won't insist, and we let this dirt persist. There's > certainly much worse. Thanks, I prefer not to rename it. Who knows what code out there relies on it being available.