all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
	Chong Yidong <cyd@stupidchicken.com>
Cc: 8047@debbugs.gnu.org
Subject: bug#8047: 23.2.94; Auto image mode breaks C-x C-w
Date: Wed, 16 Feb 2011 22:03:06 +0200	[thread overview]
Message-ID: <83fwrnwxvp.fsf@gnu.org> (raw)
In-Reply-To: <83pqqrx3pc.fsf@gnu.org>

> Date: Wed, 16 Feb 2011 19:57:19 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 8047@debbugs.gnu.org
> 
> > As for the actual fix, maybe require-final-newline should be ignored
> > when the encoding is `binary'?
> 
> That's what I have in mind; feel free to beat me to it, because I
> don't buy the argument that since this was so in Emacs 22, we need to
> live with it until 24.1.

However, since emacs-23 is in deep freeze, I would like to suggest an
even more conservative change, see below.  This one affects only
image-mode buffers that display image files.

Chong, is this okay to install on the release branch, even though the
bug predates Emacs 23.2?


--- lisp/image-mode.el~	2011-02-15 21:32:39.565125000 +0200
+++ lisp/image-mode.el	2011-02-16 21:55:04.190125000 +0200
@@ -507,6 +507,9 @@ (defun image-toggle-display-image ()
     ;; This just makes the arrow displayed in the right fringe
     ;; area look correct when the image is wider than the window.
     (setq truncate-lines t)
+    ;; Disable adding a newline at the end of the image file when it
+    ;; is written with, e.g., C-x C-w.
+    (setq find-file-literally t)
     ;; Allow navigation of large images
     (set (make-local-variable 'auto-hscroll-mode) nil)
     (setq image-type type)





  parent reply	other threads:[~2011-02-16 20:03 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-15 20:14 bug#8047: 23.2.94; Auto image mode breaks C-x C-w Eli Zaretskii
2011-02-15 23:35 ` Glenn Morris
2011-02-16  4:10   ` Eli Zaretskii
2011-02-16  4:56     ` Glenn Morris
2011-02-16 10:11     ` Andreas Schwab
2011-02-16 11:19       ` Lennart Borgman
2011-02-16 12:33         ` Andreas Schwab
2011-02-16 12:36           ` Lennart Borgman
2011-02-16 12:57             ` Andreas Schwab
2011-02-16 13:03               ` Lennart Borgman
2011-02-16 13:17                 ` Andreas Schwab
2011-02-16 13:19                   ` Lennart Borgman
2011-02-16 13:30                     ` Andreas Schwab
2011-02-16 13:37                       ` Lennart Borgman
2011-02-16 12:45           ` Deniz Dogan
2011-02-16 14:40     ` Stefan Monnier
2011-02-16 17:57       ` Eli Zaretskii
2011-02-16 18:35         ` Glenn Morris
2011-02-16 20:03         ` Eli Zaretskii [this message]
2011-02-16 20:58           ` Stefan Monnier
2011-02-16 21:08             ` Eli Zaretskii
2011-02-17  1:50               ` Stefan Monnier
2011-02-17  4:01                 ` Eli Zaretskii
2011-02-18  9:44                   ` Eli Zaretskii
2011-02-18 17:24                     ` Stefan Monnier
2011-02-18 18:00                       ` Eli Zaretskii
2011-02-19  3:38                         ` Glenn Morris
2011-02-19  8:34                           ` Eli Zaretskii
2011-02-19  9:31                             ` Stephen J. Turnbull
2011-02-19 19:25                             ` marking commits not to be merged after the fact [was Re: bug#8047: 23.2.94; Auto image mode breaks C-x C-w] Glenn Morris
2011-02-19 20:52                               ` Eli Zaretskii
2011-02-19 21:23                                 ` marking commits not to be merged after the fact Glenn Morris
2011-02-16 21:08           ` bug#8047: 23.2.94; Auto image mode breaks C-x C-w Glenn Morris
2011-02-17  3:58             ` Eli Zaretskii
2011-02-17  4:34               ` Glenn Morris
2011-02-17 10:38                 ` Eli Zaretskii
2011-02-17 20:10                   ` Stefan Monnier
2011-02-17 20:40                     ` Lennart Borgman
2011-02-18 10:24                     ` Eli Zaretskii
2011-02-16 21:43           ` Glenn Morris
2011-02-17  4:00             ` Eli Zaretskii
2011-02-16  0:48 ` Juri Linkov
2011-02-16  4:13   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fwrnwxvp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=8047@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.