bug#7840: SYMBOL_VALUE in terminal.c (was 23.2.91; default-terminal-coding-system not inherited by created terminals)

[Eli Zaretskii <eliz@gnu.org>]

> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: cyd@stupidchicken.com, 7840@debbugs.gnu.org
> Date: Fri, 18 Feb 2011 12:33:29 -0500
> 
> > I used find_symbol_value instead, which seems to be the Emacs 24
> > equivalent of SYMBOL_VALUE in this situation.
> 
> Yes, both of them are undesirable since they're internal functions used
> to implement Fsymbol_value.  Better use Fsymbol_value and Fboundp.

But find_symbol_value is used in quite a few places elsewhere in
Emacs.  That's why I thought it was kosher to use.  And
create_terminal is hardly a place where internal functions are
inappropriate to use, isn't it?

I also don't understand the "internal function" argument: it sounds
TRT to have a function that just fetches a symbol's value, without
signaling an error if it is unbound.  Fsymbol_value, as it is now, is
clearly coded for interactive use, which this isn't.

In any case, if you want people to avoid these APIs, please explain
more why you dislike them, because so far it is utterly unclear, at
least to me.