From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: bug-gnu-emacs@gnu.org
Subject: bug#8277: Emacs should use socklen_t for socket lengths
Date: Sun, 20 Mar 2011 20:08:35 +0200 [thread overview]
Message-ID: <83fwqhacm4.fsf@gnu.org> (raw)
In-Reply-To: <4D862D98.1060805@cs.ucla.edu>
> Date: Sun, 20 Mar 2011 09:38:48 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: Eli Zaretskii <eliz@gnu.org>
>
> Comments by Bruno Haible on the gnulib mailing list
> <http://lists.gnu.org/archive/html/bug-gnulib/2011-03/msg00211.html>
> showed the need for an update to that patch, for the
> benefit of Cygwin and MingW ports. I've attached it; it
> consists entirely of autogenerated files from Emacs's point
> of view. This adds a symbol HAVE_WS2TCPIP_H to src/config.in,
> which may need to be configured for MS-DOS and MS-Windows.
> I haven't committed any of this socklen_t stuff to the trunk yet,
> but plan to do so after a bit more testing.
I don't understand Bruno's comments. He probably thinks that the
Windows build uses the Posix configury, otherwise he would have
realized that, with the single exception of process.c, none of the
patched files is used in the Windows build.
So it looks like all we need to do for the native Windows build is
define socket_t and that's it. Or did I miss something?
As for the MS-DOS build of Emacs, it does not support networking, and
in fact does not even compile the parts of process.c that are being
changed (it has `subprocesses' undefined). So this is surely
irrelevant for that port.
I don't know enough about Cygwin to provide any feedback on this.
next prev parent reply other threads:[~2011-03-20 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 4:40 bug#8277: Emacs should use socklen_t for socket lengths Paul Eggert
2011-03-20 16:38 ` Paul Eggert
2011-03-20 18:08 ` Eli Zaretskii [this message]
2011-03-20 18:34 ` Paul Eggert
2011-03-20 18:45 ` Eli Zaretskii
2011-03-20 18:53 ` Paul Eggert
2011-03-20 19:22 ` Eli Zaretskii
2011-03-20 19:40 ` Paul Eggert
2011-03-20 20:36 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fwqhacm4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=bug-gnu-emacs@gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.