From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Sat, 14 Jan 2012 10:00:25 +0200 Message-ID: <83fwfik92e.fsf@gnu.org> References: <87mx9su32g.fsf@web.de> <87sjjkfvwt.fsf@gmail.com> <8362ggkquq.fsf@gnu.org> <87lipcrlga.fsf@gmail.com> <87fwfkc4pn.fsf@gmx.de> <87fwfjsw8t.fsf@gmail.com> <87aa5rdazl.fsf@gmx.de> <87d3anogf5.fsf@gmail.com> <011AEED9E81C4DEFA6B1E03B0F57F28F@us.oracle.com> <878vlbljnc.fsf@gmx.de> <8739bj8mu1.fsf@gmail.com> <87fwfjo24c.fsf@gmx.de> <87pqen76p4.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1326528093 3667 80.91.229.12 (14 Jan 2012 08:01:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 14 Jan 2012 08:01:33 +0000 (UTC) Cc: 10489@debbugs.gnu.org, michael.albinus@gmx.de To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 14 09:01:29 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RlyYK-00070y-6v for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jan 2012 09:01:28 +0100 Original-Received: from localhost ([::1]:50669 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlyYI-0002IH-Fw for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jan 2012 03:01:26 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:56760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlyYF-0002FU-OA for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2012 03:01:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlyYD-0004KT-NX for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2012 03:01:23 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlyYD-0004KP-JK for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2012 03:01:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RlyYs-0004Nf-GE for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2012 03:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jan 2012 08:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.132652811316822 (code B ref 10489); Sat, 14 Jan 2012 08:02:02 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 14 Jan 2012 08:01:53 +0000 Original-Received: from localhost ([127.0.0.1]:57047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RlyYj-0004NH-Dl for submit@debbugs.gnu.org; Sat, 14 Jan 2012 03:01:53 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:47765) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RlyYg-0004N8-8C for 10489@debbugs.gnu.org; Sat, 14 Jan 2012 03:01:51 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LXS00N0038Z4H00@a-mtaout22.012.net.il> for 10489@debbugs.gnu.org; Sat, 14 Jan 2012 10:00:19 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.124.136.230]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LXS00MUE3KIDPC0@a-mtaout22.012.net.il>; Sat, 14 Jan 2012 10:00:19 +0200 (IST) In-reply-to: <87pqen76p4.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55729 Archived-At: > From: Thierry Volpiatto > Date: Fri, 13 Jan 2012 20:17:43 +0100 > Cc: 10489@debbugs.gnu.org > > (defun dired-copy-file-recursive (from to ok-flag &optional > preserve-time top recursive) > - (let ((attrs (file-attributes from))) > + (let* ((case-fold-search t) > + (fromname (file-name-as-directory (file-truename from))) > + (destname (file-name-as-directory (file-truename to))) > + (rem-dirname (and (equal "sudo" (file-remote-p fromname 'method)) > + (file-remote-p fromname 'localname))) > + (rem-newname (and (equal "sudo" (file-remote-p destname 'method)) > + (file-remote-p destname 'localname))) > + (attrs (file-attributes from))) > + (when (equal (or rem-dirname fromname) > + (or rem-newname destname)) > + (error "Can't copy directory `%s' on itself" from)) Why is case-fold-search being unconditionally bound to t? I don't think this is TRT on case-sensitive filesystems. Am I missing something?