From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: dmantipov@yandex.ru, emacs-devel@gnu.org
Subject: Re: 'struct window' cleanup #4
Date: Mon, 02 Jul 2012 20:07:18 +0300 [thread overview]
Message-ID: <83fw9a5by1.fsf@gnu.org> (raw)
In-Reply-To: <jwv4npqte53.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 02 Jul 2012 10:48:08 -0400
> Cc: Emacs development discussions <emacs-devel@gnu.org>
>
> vscroll should be int, as should be the hscroll amounts.
> The vpos probably as well.
I agree, on all 3 counts. Since the corresponding coordinates in
pixel units (current_x and current_y from 'struct it'), which are
typically about 10 times larger than the above 3, are ints, it doesn't
make sense to have these declared as ptrdiff_t.
Vertical and horizontal screen positions are generally the size of the
Emacs window, i.e. bounded by the display size. (Some internal Emacs
display routines simulate a larger window for the purposes of
adjusting the displayed area, e.g., while scrolling. But they never
go too far outside the display dimensions, because doing so makes the
display sluggish, and people complain sooner or later.) Those values
are a far cry from being anywhere near INT_MAX.
next prev parent reply other threads:[~2012-07-02 17:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 10:45 'struct window' cleanup #4 Dmitry Antipov
2012-07-02 14:48 ` Stefan Monnier
2012-07-02 17:07 ` Eli Zaretskii [this message]
2012-07-02 17:33 ` Eli Zaretskii
2012-07-03 5:54 ` 'struct window' cleanup #5 [Re: 'struct window' cleanup #4] Dmitry Antipov
2012-07-03 15:58 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fw9a5by1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.