From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18136: 24.4.50; crash in redisplay when calling load-theme Date: Tue, 29 Jul 2014 21:29:13 +0300 Message-ID: <83fvhkt3wm.fsf@gnu.org> References: <87d2cpxaq1.fsf@holos.localdomain> <8338dkh6wo.fsf@gnu.org> <53D77B06.8040907@gmx.at> <83tx60fjnh.fsf@gnu.org> <53D7A965.30700@gmx.at> <83mwbste5o.fsf@gnu.org> <53D7C0C4.7070406@gmx.at> <83iomgt9d2.fsf@gnu.org> <53D7E6B6.6070007@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1406658626 8292 80.91.229.3 (29 Jul 2014 18:30:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Jul 2014 18:30:26 +0000 (UTC) Cc: mvoteiza@udel.edu, 18136@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 29 20:30:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XCCAE-0000rx-4d for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jul 2014 20:30:18 +0200 Original-Received: from localhost ([::1]:47463 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCCAD-0000HR-Kk for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jul 2014 14:30:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCCA6-0000GT-33 for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 14:30:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCCA0-0000Zx-Sw for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 14:30:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCCA0-0000Yv-QR for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 14:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XCC9z-0008KI-VU for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 14:30:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Jul 2014 18:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18136 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18136-submit@debbugs.gnu.org id=B18136.140665855231923 (code B ref 18136); Tue, 29 Jul 2014 18:30:03 +0000 Original-Received: (at 18136) by debbugs.gnu.org; 29 Jul 2014 18:29:12 +0000 Original-Received: from localhost ([127.0.0.1]:42279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XCC96-0008Ih-6q for submit@debbugs.gnu.org; Tue, 29 Jul 2014 14:29:11 -0400 Original-Received: from mtaout26.012.net.il ([80.179.55.182]:39594) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XCC90-0008I9-RB for 18136@debbugs.gnu.org; Tue, 29 Jul 2014 14:29:06 -0400 Original-Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0N9H00E00K98W600@mtaout26.012.net.il> for 18136@debbugs.gnu.org; Tue, 29 Jul 2014 21:25:20 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N9H008OQKI83570@mtaout26.012.net.il>; Tue, 29 Jul 2014 21:25:20 +0300 (IDT) In-reply-to: <53D7E6B6.6070007@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91950 Archived-At: > Date: Tue, 29 Jul 2014 20:23:50 +0200 > From: martin rudalics > CC: mvoteiza@udel.edu, 18136@debbugs.gnu.org > > > Shouldn't TTY frames behave as if they were fullscreen? That's what > > they (normally) are, right? > > I think so, especially because that's how they behaved before. If so, we agree, and this means the menu bar should be part of the TTY frame's dimensions. > > The code in change_frame_size_1 we are talking about was there since a > > very long time (I see it in Emacs 21), and its purpose is to update > > FrameRows and FrameCols when the user changes dimensions of a TTY > > frame (e.g., by calling set-frame-height). If you remove it, how can > > we update those attributes otherwise? > > I wonder why this is done in this part of the code. Here we resize the > windows of a frame but the frame's sizes remain unchanged. No, we resize the frame and then redistribute the frame dimensions between its windows. When change_frame_size_1 is called with the same dimensions as the current frame's dimensions, it simply does nothing and returns.